linux-kernel - Re: [PATCH] arc: rename arc_timer's TIMER_CTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Jul 2021 23:03:16 +0000
From:   Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "linux-snps-arc@...ts.infradead.org" 
        <linux-snps-arc@...ts.infradead.org>
Subject: Re: [PATCH] arc: rename arc_timer's TIMER_CTRL_IE to avoid
 redefinition

On 7/18/21 1:36 PM, Randy Dunlap wrote:
> There are 2 other clocksource drivers that use the symbol
> (macro/define) TIMER_CTRL_IE (in 3 files). Change the ARC timer
> symbol "TIMER_CTRL_IE" to "TIMER_CTRL_IEN" to resolve the symbol
> collision (redefinition).
>
> In file included from ../drivers/clocksource/timer-integrator-ap.c:17:
> ../drivers/clocksource/timer-sp.h:25: warning: "TIMER_CTRL_IE" redefined
>     25 | #define TIMER_CTRL_IE  (1 << 5) /*   VR */
> ../include/soc/arc/timers.h:20: note: this is the location of the previous definition
>     20 | #define TIMER_CTRL_IE         (1 << 0) /* Interrupt when Count reaches limit */
>
> ../drivers/clocksource/mps2-timer.c:25: warning: "TIMER_CTRL_IE" redefined
>     25 | #define TIMER_CTRL_IE  BIT(3)
> ../include/soc/arc/timers.h:20: note: this is the location of the previous definition
>     20 | #define TIMER_CTRL_IE         (1 << 0) /* Interrupt when Count reaches limit */
>
> In file included from ../drivers/clocksource/timer-sp804.c:24:
> ../drivers/clocksource/timer-sp.h:25: warning: "TIMER_CTRL_IE" redefined
>     25 | #define TIMER_CTRL_IE  (1 << 5) /*   VR */
> ../include/soc/arc/timers.h:20: note: this is the location of the previous definition
>     20 | #define TIMER_CTRL_IE         (1 << 0) /* Interrupt when Count reaches limit */
>
> Fixes: b26c2e3823ba ("ARC: breakout timer include code into separate header")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: linux-snps-arc@...ts.infradead.org

Acked-by: Vineet Gupta <vgupta@...opsys.com>

Thx,
-Vineet