linux-kernel - Re: [patch] v2 mm/slub: restore/expand unfreeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 18 Jul 2021 10:11:53 +0200
From:   Mike Galbraith <efault@....de>
To:     Vlastimil Babka <vbabka@...e.cz>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     linux-rt-users@...r.kernel.org,
        Mel Gorman <mgorman@...hsingularity.net>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [patch] v2 mm/slub: restore/expand unfreeze_partials() local
 exclusion scope

On Sun, 2021-07-18 at 09:58 +0200, Vlastimil Babka wrote:
> On 7/17/21 4:58 PM, Mike Galbraith wrote:
> > On Thu, 2021-07-15 at 18:34 +0200, Mike Galbraith wrote:
> > > Greetings crickets,
> > >
> > > Methinks he problem is the hole these patches opened only for RT.
> > >
> > > static void put_cpu_partial(struct kmem_cache *s, struct page
> > > *page,
> > > int drain)
> > > {
> > > #ifdef CONFIG_SLUB_CPU_PARTIAL
> > > 	struct page *oldpage;
> > > 	int pages;
> > > 	int pobjects;
> > >
> > > 	slub_get_cpu_ptr(s->cpu_slab);
> > >         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > Bah, I'm tired of waiting to see what if anything mm folks do about
> > this little bugger, so I'm gonna step on it my damn self and be
> > done
> > with it.  Fly or die little patchlet.
>
> Sorry, Mike. Got some badly timed sickness. Will check ASAP.

Hey, no apology necessary.  I have no way of knowing what's going on
behind the scenes, but I also didn't like the notion of just walking
away from a busted thing, so given the silence, figured it's better to
post the working something I've got (wart and all) than to let the bug
go unchallenged.  (take that damn bug.. pokes it with sharp stick;)

	-Mike