linux-kernel - Re: [PATCH 1/2] swap led_brightness from enum to typedef

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Jul 2021 11:21:41 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     kbuild@...ts.01.org, Amy Parker <apark0006@...dent.cerritos.edu>,
        pavel@....cz
Cc:     lkp@...el.com, kbuild-all@...ts.01.org,
        Amy Parker <apark0006@...dent.cerritos.edu>,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] swap led_brightness from enum to typedef

Hi Amy,

url:    https://github.com/0day-ci/linux/commits/Amy-Parker/leds-change-led_brightness-definition-from-enum-to-typedef/20210716-052140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git dd9c7df94c1b23feacd54112f33ad95d93f64533
config: x86_64-randconfig-m001-20210718 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

smatch warnings:
drivers/platform/chrome/cros_kbd_led_backlight.c:53 keyboard_led_get_brightness() warn: signedness bug returning '(-5)'
drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: impossible condition '(value < 0) => (0-255 < 0)'

vim +53 drivers/platform/chrome/cros_kbd_led_backlight.c

b14a971f104520 Amy Parker 2021-07-15  42  static led_brightness
                                                 ^^^^^^^^^^^^^^

492ef7829d2d09 Simon Que  2016-03-08  43  keyboard_led_get_brightness(struct led_classdev *cdev)
492ef7829d2d09 Simon Que  2016-03-08  44  {
492ef7829d2d09 Simon Que  2016-03-08  45  	unsigned long long brightness;
492ef7829d2d09 Simon Que  2016-03-08  46  	acpi_status status;
492ef7829d2d09 Simon Que  2016-03-08  47  
492ef7829d2d09 Simon Que  2016-03-08  48  	status = acpi_evaluate_integer(NULL, ACPI_KEYBOARD_BACKLIGHT_READ,
492ef7829d2d09 Simon Que  2016-03-08  49  				       NULL, &brightness);
492ef7829d2d09 Simon Que  2016-03-08  50  	if (ACPI_FAILURE(status)) {
492ef7829d2d09 Simon Que  2016-03-08  51  		dev_err(cdev->dev, "Error getting keyboard LED value: %d\n",
492ef7829d2d09 Simon Que  2016-03-08  52  			status);
492ef7829d2d09 Simon Que  2016-03-08 @53  		return -EIO;
                                                        ^^^^^^^^^^^^
To be honest, I'm confused why we are changing this from an enum to a
typedef.  In the kernel we generally avoid typedefs where possible.
What's the problem that using a typedef fixes?

Also probably the name should end in a _t.

492ef7829d2d09 Simon Que  2016-03-08  54  	}
492ef7829d2d09 Simon Que  2016-03-08  55  
492ef7829d2d09 Simon Que  2016-03-08  56  	return brightness;
492ef7829d2d09 Simon Que  2016-03-08  57  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org