lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Jul 2021 22:00:23 +0530 From: Sibi Sankar <sibis@...eaurora.org> To: Rob Herring <robh@...nel.org> Cc: bjorn.andersson@...aro.org, swboyd@...omium.org, ulf.hansson@...aro.org, rjw@...ysocki.net, agross@...nel.org, ohad@...ery.com, mathieu.poirier@...aro.org, linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dianders@...omium.org, rishabhb@...eaurora.org, sidgup@...eaurora.org Subject: Re: [PATCH v3 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP bindings On 2021-07-15 01:04, Rob Herring wrote: > On Fri, Jun 25, 2021 at 12:21:56AM +0530, Sibi Sankar wrote: >> Add Qualcomm Mailbox Protocol (QMP) binding to replace the power >> domains >> exposed by the AOSS QMP node. > > Not a compatible change. Explain why that's okay for all > platforms/users. It's not meant for all platforms. Rather we just replace the load-state power-domain with the new qmp property and it only affects the compatibles covered below. > >> >> Signed-off-by: Sibi Sankar <sibis@...eaurora.org> >> --- >> >> v3: >> * Misc. documentation fixes: >> - Reduce power-domain maxItems due to load_state pd removal >> - Combine compatibles where possible with the load_state pd removal >> - Fixup the qcom,qmp ref to phandle type >> >> .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 62 >> +++++++++++----------- >> 1 file changed, 30 insertions(+), 32 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> index 9ea05e608bc1..ad85617b43fa 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> @@ -75,11 +75,11 @@ properties: >> >> power-domains: >> minItems: 1 >> - maxItems: 3 >> + maxItems: 2 >> >> power-domain-names: >> minItems: 1 >> - maxItems: 3 >> + maxItems: 2 >> >> firmware-name: >> $ref: /schemas/types.yaml#/definitions/string >> @@ -89,6 +89,10 @@ properties: >> maxItems: 1 >> description: Reference to the reserved-memory for the Hexagon >> core >> >> + qcom,qmp: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: Reference to the AOSS side-channel message RAM. >> + >> qcom,smem-states: >> $ref: /schemas/types.yaml#/definitions/phandle-array >> description: States used by the AP to signal the Hexagon core >> @@ -359,13 +363,11 @@ allOf: >> properties: >> power-domains: >> items: >> - - description: Load State power domain >> - description: CX power domain >> - description: MX power domain >> - description: MSS power domain >> power-domain-names: >> items: >> - - const: load_state >> - const: cx >> - const: mx >> - const: mss >> @@ -381,43 +383,20 @@ allOf: >> properties: >> power-domains: >> items: >> - - description: Load State power domain >> - description: CX power domain >> - power-domain-names: >> - items: >> - - const: load_state >> - - const: cx >> >> - if: >> properties: >> compatible: >> contains: >> enum: >> + - qcom,sdx55-mpss-pas >> - qcom,sm8150-mpss-pas >> - qcom,sm8350-mpss-pas >> then: >> properties: >> power-domains: >> items: >> - - description: Load State power domain >> - - description: CX power domain >> - - description: MSS power domain >> - power-domain-names: >> - items: >> - - const: load_state >> - - const: cx >> - - const: mss >> - >> - - if: >> - properties: >> - compatible: >> - contains: >> - enum: >> - - qcom,sdx55-mpss-pas >> - then: >> - properties: >> - power-domains: >> - items: >> - description: CX power domain >> - description: MSS power domain >> power-domain-names: >> @@ -439,12 +418,10 @@ allOf: >> properties: >> power-domains: >> items: >> - - description: Load State power domain >> - description: LCX power domain >> - description: LMX power domain >> power-domain-names: >> items: >> - - const: load_state >> - const: lcx >> - const: lmx >> >> @@ -458,12 +435,10 @@ allOf: >> properties: >> power-domains: >> items: >> - - description: Load State power domain >> - description: CX power domain >> - description: MXC power domain >> power-domain-names: >> items: >> - - const: load_state >> - const: cx >> - const: mxc >> >> @@ -499,6 +474,29 @@ allOf: >> - const: mss_restart >> - const: pdc_reset >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,sc7180-mpss-pas >> + - qcom,sm8150-adsp-pas >> + - qcom,sm8150-cdsp-pas >> + - qcom,sm8150-mpss-pas >> + - qcom,sm8150-slpi-pas >> + - qcom,sm8250-adsp-pas >> + - qcom,sm8250-cdsp-pas >> + - qcom,sm8250-slpi-pas >> + - qcom,sm8350-adsp-pas >> + - qcom,sm8350-cdsp-pas >> + - qcom,sm8350-mpss-pas >> + - qcom,sm8350-slpi-pas >> + then: >> + properties: >> + qcom,qmp: >> + items: >> + - description: Reference to the AOSS side-channel message >> RAM. >> + >> examples: >> - | >> #include <dt-bindings/clock/qcom,rpmcc.h> >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >> >> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Powered by blists - more mailing lists