lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 19 Jul 2021 14:07:41 -0400 From: Nitesh Narayan Lal <nitesh@...hat.com> To: linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org, linux-api@...r.kernel.org, linux-pci@...r.kernel.org, tglx@...utronix.de, jesse.brandeburg@...el.com, robin.murphy@....com, mtosatti@...hat.com, mingo@...nel.org, jbrandeb@...nel.org, frederic@...nel.org, juri.lelli@...hat.com, abelits@...vell.com, bhelgaas@...gle.com, rostedt@...dmis.org, peterz@...radead.org, davem@...emloft.net, akpm@...ux-foundation.org, sfr@...b.auug.org.au, stephen@...workplumber.org, rppt@...ux.vnet.ibm.com, chris.friesen@...driver.com, maz@...nel.org, nhorman@...driver.com, pjwaskiewicz@...il.com, sassmann@...hat.com, thenzl@...hat.com, kashyap.desai@...adcom.com, sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com, sathya.prakash@...adcom.com, sreekanth.reddy@...adcom.com, suganath-prabu.subramani@...adcom.com, james.smart@...adcom.com, dick.kennedy@...adcom.com, jkc@...hat.com, faisal.latif@...el.com, shiraz.saleem@...el.com, tariqt@...dia.com, ahleihel@...hat.com, kheib@...hat.com, borisp@...dia.com, saeedm@...dia.com, benve@...co.com, govind@....com, jassisinghbrar@...il.com, ajit.khaparde@...adcom.com, sriharsha.basavapatna@...adcom.com, somnath.kotur@...adcom.com, nilal@...hat.com, tatyana.e.nikolova@...el.com, mustafa.ismail@...el.com, ahs3@...hat.com, leonro@...dia.com, chandrakanth.patil@...adcom.com, bjorn.andersson@...aro.org, chunkuang.hu@...nel.org, yongqiang.niu@...iatek.com, baolin.wang7@...il.com, poros@...hat.com, minlei@...hat.com, emilne@...hat.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, _govind@....com, ley.foon.tan@...el.com, kabel@...nel.org, viresh.kumar@...aro.org, Tushar.Khandelwal@....com, luobin9@...wei.com Subject: [PATCH v4 09/14] ixgbe: Use irq_update_affinity_hint The driver uses irq_set_affinity_hint() to update the affinity_hint mask that is consumed by the userspace to distribute the interrupts. However, under the hood irq_set_affinity_hint() also applies the provided cpumask (if not NULL) as the affinity for the given interrupt which is an undocumented side effect. To remove this side effect irq_set_affinity_hint() has been marked as deprecated and new interfaces have been introduced. Hence, replace the irq_set_affinity_hint() with the new interface irq_update_affinity_hint() that only updates the affinity_hint pointer. Signed-off-by: Nitesh Narayan Lal <nitesh@...hat.com> Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com> --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index 913253f8ecb4..3b7db68ef860 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -3241,8 +3241,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter) /* If Flow Director is enabled, set interrupt affinity */ if (adapter->flags & IXGBE_FLAG_FDIR_HASH_CAPABLE) { /* assign the mask for this irq */ - irq_set_affinity_hint(entry->vector, - &q_vector->affinity_mask); + irq_update_affinity_hint(entry->vector, + &q_vector->affinity_mask); } } @@ -3258,8 +3258,8 @@ static int ixgbe_request_msix_irqs(struct ixgbe_adapter *adapter) free_queue_irqs: while (vector) { vector--; - irq_set_affinity_hint(adapter->msix_entries[vector].vector, - NULL); + irq_update_affinity_hint(adapter->msix_entries[vector].vector, + NULL); free_irq(adapter->msix_entries[vector].vector, adapter->q_vector[vector]); } @@ -3392,7 +3392,7 @@ static void ixgbe_free_irq(struct ixgbe_adapter *adapter) continue; /* clear the affinity_mask in the IRQ descriptor */ - irq_set_affinity_hint(entry->vector, NULL); + irq_update_affinity_hint(entry->vector, NULL); free_irq(entry->vector, q_vector); } -- 2.27.0
Powered by blists - more mailing lists