linux-kernel - Re: [PATCH v3 3/3] ima: Add digest and digest_len params to the functions to measure a buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2f33ad4dca9eba9b2a05a00de571e9f94022343.camel@linux.ibm.com>
Date:   Mon, 19 Jul 2021 16:59:32 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>, paul@...l-moore.com
Cc:     stephen.smalley.work@...il.com, prsriva02@...il.com,
        tusharsu@...ux.microsoft.com, nramas@...ux.microsoft.com,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, selinux@...r.kernel.org
Subject: Re: [PATCH v3 3/3] ima: Add digest and digest_len params to the
 functions to measure a buffer

Hi Roberto,

On Mon, 2021-07-05 at 11:09 +0200, Roberto Sassu wrote:
> This patch adds the 'digest' and 'digest_len' parameters to
> ima_measure_critical_data() and process_buffer_measurement(), so that
> callers can get the digest of the passed buffer.
> 
> These functions calculate the digest even if there is no suitable rule in
> the IMA policy and, in this case, they simply return 1 before generating a
> new measurement entry.

I agree ima_measure_critical_data() is special.  Both this patch
description and 1/3 describe "what", not "why".  Please provide the
motivation for these changes at least in the cover letter, if not in
the patch description.

thanks,

Mimi