linux-kernel - Re: [PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202107191617.GTgifw9l-lkp@intel.com>
Date:   Mon, 19 Jul 2021 16:28:07 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vinod Koul <vkoul@...nel.org>, Rob Clark <robdclark@...il.com>
Cc:     kbuild-all@...ts.01.org, Jonathan Marek <jonathan@...ek.ca>,
        Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
        David Airlie <airlied@...ux.ie>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Abhinav Kumar <abhinavk@...eaurora.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Vinod Koul <vkoul@...nel.org>, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 02/11] drm/msm/disp/dpu1: Add support for DSC

Hi Vinod,

I love your patch! Perhaps something to improve:

[auto build test WARNING on v5.13]
[also build test WARNING on next-20210716]
[cannot apply to linus/master v5.14-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20210715-145540
base:    62fb9874f5da54fdb243003b386128037319b219
config: arm-defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/032a82b57221a13f65c55870ae3f64d0e5a07390
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vinod-Koul/drm-msm-Add-Display-Stream-Compression-Support/20210715-145540
        git checkout 032a82b57221a13f65c55870ae3f64d0e5a07390
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c: In function 'dpu_hw_dsc_config_thresh':
>> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c:128:7: warning: variable 'lp' set but not used [-Wunused-but-set-variable]
     128 |  u16 *lp;
         |       ^~


vim +/lp +128 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c

   121	
   122	static void dpu_hw_dsc_config_thresh(struct dpu_hw_dsc *hw_dsc,
   123					     struct msm_display_dsc_config *dsc)
   124	{
   125		struct drm_dsc_rc_range_parameters *rc = dsc->drm->rc_range_params;
   126		struct dpu_hw_blk_reg_map *c = &hw_dsc->hw;
   127		u32 off;
 > 128		u16 *lp;
   129		int i;
   130	
   131		lp = dsc->drm->rc_buf_thresh;
   132		off = DSC_RC_BUF_THRESH;
   133		for (i = 0; i < DSC_NUM_BUF_RANGES - 1 ; i++) {
   134			DPU_REG_WRITE(c, off, dsc->drm->rc_buf_thresh[i]);
   135			off += 4;
   136		}
   137	
   138		off = DSC_RANGE_MIN_QP;
   139		for (i = 0; i < DSC_NUM_BUF_RANGES; i++) {
   140			DPU_REG_WRITE(c, off, rc[i].range_min_qp);
   141			off += 4;
   142		}
   143	
   144		off = DSC_RANGE_MAX_QP;
   145		for (i = 0; i < 15; i++) {
   146			DPU_REG_WRITE(c, off, rc[i].range_max_qp);
   147			off += 4;
   148		}
   149	
   150		off = DSC_RANGE_BPG_OFFSET;
   151		for (i = 0; i < 15; i++) {
   152			DPU_REG_WRITE(c, off, rc[i].range_bpg_offset);
   153			off += 4;
   154		}
   155	}
   156	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (54713 bytes)