linux-kernel - Re: [PATCH][RESEND] power: supply: ab8500: clean up warnings found by cppcheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210719102124.GT1931@kadam>
Date:   Mon, 19 Jul 2021 13:21:25 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RESEND] power: supply: ab8500: clean up warnings found
 by cppcheck

On Mon, Jul 19, 2021 at 11:16:48AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Clean up a handful of checkpatch warnings:

The subject says cppcheck but it's actually checkpatch.

>  - static const char * array should probably be static const char * const
>  - function arguments should have identifier names
>  - else should follow close brace '}'
>  - suspect code indent for conditional statements
>  - unnecessary parentheses in an if condition
>  - avoid multiple line dereference
>  - prefer using '"%s...", __func__' to using 'ab8500_chargalg_wd_work'

This printk should just be deleted.  Use ftrace instea.

>  - prefer 'long' over 'long int' as the int is unnecessary
> 

regards,
dan carpenter