linux-kernel - Re: [PATCH v3] HID: cmedia: add support for HS-100B mute button

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dded786c-e27e-4d78-999c-af99f3778c11@t-8ch.de>
Date:   Mon, 19 Jul 2021 13:24:57 +0200
From:   Thomas Weißschuh <linux@...ssschuh.net>
To:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        linux-input@...r.kernel.org, Ben Chen <ben_chen@...linktech.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] HID: cmedia: add support for HS-100B mute button

On Mo, 2021-07-19T13:09+0200, Thomas Weißschuh wrote:
> These chips report mute button events in bit 4 of their report without
> it being part of the report descriptor.
> Use a custom descriptor that maps this bit.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> v1: https://lore.kernel.org/linux-input/a769ae40-6d0c-47c4-803f-2c8dbc362f24@t-8ch.de/
> 
> v1 -> v2:
>  * Merged into the existing cmedia driver instead of creating a dedicated
>    driver.
> 
> v2: https://lore.kernel.org/linux-input/20210716160659.154779-1-linux@weissschuh.net/
> 
> v2 -> v3:
>  * Fixed cosmetic checkpatch warnings
>  * CC-ed Ben Chen who is the original author of hid-cmedia.c
> 
>  drivers/hid/Kconfig      |  5 +-
>  drivers/hid/hid-cmedia.c | 99 +++++++++++++++++++++++++++++++++++-----
>  drivers/hid/hid-ids.h    |  1 +
>  drivers/hid/hid-quirks.c |  1 +
>  4 files changed, 93 insertions(+), 13 deletions(-)
> 

FYI:
The Mail to Ben bounced, so we will probably have to do without his review.

Thomas