linux-kernel - Re: [PATCH] clk: hisilicon: hi3559a: select RESET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABSBigROX2sYdcOOt=L45_hhdz9reff3t1rD-6M2vDLQ35LcOQ@mail.gmail.com>
Date:   Mon, 19 Jul 2021 10:55:36 +0800
From:   Dongjiu Geng <gengdongjiu1@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>,
        Dongjiu Geng <gengdongjiu@...wei.com>,
        Stephen Boyd <sboyd@...nel.org>, stable@...r.kernel.org,
        linux-clk@...r.kernel.org,
        Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH] clk: hisilicon: hi3559a: select RESET_HISI

Randy Dunlap <rdunlap@...radead.org> 于2021年7月17日周六 下午12:34写道：
>
> The clk-hi3559a driver uses functions from reset.c so it should
> select RESET_HISI to avoid build errors.
>
> Fixes these build errors:
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_remove':
> clk-hi3559a.c:(.text+0x158): undefined reference to `hisi_reset_exit'
> aarch64-linux-ld: drivers/clk/hisilicon/clk-hi3559a.o: in function `hi3559av100_crg_probe':
> clk-hi3559a.c:(.text+0x1f4): undefined reference to `hisi_reset_init'
> aarch64-linux-ld: clk-hi3559a.c:(.text+0x238): undefined reference to `hisi_reset_exit'
>
> Fixes: 6c81966107dc ("clk: hisilicon: Add clock driver for hi3559A SoC")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Dongjiu Geng <gengdongjiu@...wei.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: stable@...r.kernel.org
> Cc: linux-clk@...r.kernel.org
> Cc: Michael Turquette <mturquette@...libre.com>
> ---
>  drivers/clk/hisilicon/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-next-20210716.orig/drivers/clk/hisilicon/Kconfig
> +++ linux-next-20210716/drivers/clk/hisilicon/Kconfig
> @@ -18,6 +18,7 @@ config COMMON_CLK_HI3519
>  config COMMON_CLK_HI3559A
>         bool "Hi3559A Clock Driver"
>         depends on ARCH_HISI || COMPILE_TEST
> +       select RESET_HISI
>         default ARCH_HISI
>         help
>           Build the clock driver for hi3559a.

Reviewed-by: Dongjiu Geng <gengdongjiu1@...il.com>