linux-kernel - [allisonhenderson-xfs_work:delayed_attrs_v21_extended 39/62] fs/xfs/xfs_attr_item.c:292:1: warning: no previous prototype for 'xfs_trans_attr_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 19 Jul 2021 11:06:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Allison Henderson <allison.henderson@...cle.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [allisonhenderson-xfs_work:delayed_attrs_v21_extended 39/62]
 fs/xfs/xfs_attr_item.c:292:1: warning: no previous prototype for
 'xfs_trans_attr_finish_update'

tree:   https://github.com/allisonhenderson/xfs_work.git delayed_attrs_v21_extended
head:   1a71ced599b41e7ee9f0ea02427b76c30f71f7dd
commit: ba1114fc490c84643980a816cfc54ae8f5da1dd3 [39/62] xfs: Implement attr logging and replay
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/allisonhenderson/xfs_work/commit/ba1114fc490c84643980a816cfc54ae8f5da1dd3
        git remote add allisonhenderson-xfs_work https://github.com/allisonhenderson/xfs_work.git
        git fetch --no-tags allisonhenderson-xfs_work delayed_attrs_v21_extended
        git checkout ba1114fc490c84643980a816cfc54ae8f5da1dd3
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> fs/xfs/xfs_attr_item.c:292:1: warning: no previous prototype for 'xfs_trans_attr_finish_update' [-Wmissing-prototypes]
     292 | xfs_trans_attr_finish_update(
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> fs/xfs/xfs_attr_item.c:497:1: warning: no previous prototype for 'xfs_trans_get_attrd' [-Wmissing-prototypes]
     497 | xfs_trans_get_attrd(struct xfs_trans  *tp,
         | ^~~~~~~~~~~~~~~~~~~


vim +/xfs_trans_attr_finish_update +292 fs/xfs/xfs_attr_item.c

   284	
   285	/*
   286	 * Performs one step of an attribute update intent and marks the attrd item
   287	 * dirty..  An attr operation may be a set or a remove.  Note that the
   288	 * transaction is marked dirty regardless of whether the operation succeeds or
   289	 * fails to support the ATTRI/ATTRD lifecycle rules.
   290	 */
   291	int
 > 292	xfs_trans_attr_finish_update(
   293		struct xfs_delattr_context	*dac,
   294		struct xfs_attrd_log_item	*attrdp,
   295		struct xfs_buf			**leaf_bp,
   296		uint32_t			op_flags)
   297	{
   298		struct xfs_da_args		*args = dac->da_args;
   299		int				error;
   300	
   301		error = xfs_qm_dqattach_locked(args->dp, 0);
   302		if (error)
   303			return error;
   304	
   305		switch (op_flags) {
   306		case XFS_ATTR_OP_FLAGS_SET:
   307			args->op_flags |= XFS_DA_OP_ADDNAME;
   308			error = xfs_attr_set_iter(dac, leaf_bp);
   309			break;
   310		case XFS_ATTR_OP_FLAGS_REMOVE:
   311			ASSERT(XFS_IFORK_Q(args->dp));
   312			error = xfs_attr_remove_iter(dac);
   313			break;
   314		default:
   315			error = -EFSCORRUPTED;
   316			break;
   317		}
   318	
   319		/*
   320		 * Mark the transaction dirty, even on error. This ensures the
   321		 * transaction is aborted, which:
   322		 *
   323		 * 1.) releases the ATTRI and frees the ATTRD
   324		 * 2.) shuts down the filesystem
   325		 */
   326		args->trans->t_flags |= XFS_TRANS_DIRTY;
   327	
   328		/*
   329		 * attr intent/done items are null when delayed attributes are disabled
   330		 */
   331		if (attrdp)
   332			set_bit(XFS_LI_DIRTY, &attrdp->attrd_item.li_flags);
   333	
   334		return error;
   335	}
   336	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (66573 bytes)