linux-kernel - Re: [PATCH] PCI: endpoint: Use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af1d4c61-53ff-f4e9-a708-33251b7e6470@socionext.com>
Date:   Mon, 19 Jul 2021 23:54:52 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Use sysfs_emit() in "show" functions

Hi Krzysztof,

Thank you for reviewing.

On 2021/07/19 12:43, Krzysztof Wilczyński wrote:
> Hello Hayashi-san,
> 
> Thank you for sending the patch over!
> 
>> Convert sprintf() in sysfs "show" functions to sysfs_emit() in order to
>> check for buffer overruns in sysfs outputs.
> 
> Nice catch!

I actually executed "cat" against configfs to meet the issue and found
your solution in pci-sysfs.

> 
> A small nitpick: what you are changing here are technically not sysfs
> objects since all of these are related to configfs.  Having said that,
> configfs shares the same semantics for normal attributes with sysfs, so
> a maximum size of PAGE_SIZE applies here too, and thus sysfs_emit()
> would work fine.

Thank you for helpful information.
I understand that applying sysfs_emit() to configfs is no problem.

> 
> Thank you for taking care of this!
> 
> Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>
> 
> 	Krzysztof
> 
Thank you,

---
Best Regards
Kunihiko Hayashi