linux-kernel - [RFC PATCH allisonhenderson-xfs_work] xfs: xfs_trans_attr_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210719034442.GA51111@67baee1309a0>
Date:   Mon, 19 Jul 2021 11:44:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Allison Henderson <allison.henderson@...cle.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [RFC PATCH allisonhenderson-xfs_work] xfs:
 xfs_trans_attr_finish_update can be static

fs/xfs/xfs_attr_item.c:292:1: warning: symbol 'xfs_trans_attr_finish_update' was not declared. Should it be static?
fs/xfs/xfs_attr_item.c:496:27: warning: symbol 'xfs_trans_get_attrd' was not declared. Should it be static?

Fixes: ba1114fc490c ("xfs: Implement attr logging and replay")
Reported-by: kernel test robot <lkp@...el.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---
 xfs_attr_item.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index eda6ae3a39880..7d77de9e12781 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -288,7 +288,7 @@ xfs_attrd_item_release(
  * transaction is marked dirty regardless of whether the operation succeeds or
  * fails to support the ATTRI/ATTRD lifecycle rules.
  */
-int
+static int
 xfs_trans_attr_finish_update(
 	struct xfs_delattr_context	*dac,
 	struct xfs_attrd_log_item	*attrdp,
@@ -493,7 +493,7 @@ xfs_attri_item_match(
 /*
  * This routine is called to allocate an "attr free done" log item.
  */
-struct xfs_attrd_log_item *
+static struct xfs_attrd_log_item *
 xfs_trans_get_attrd(struct xfs_trans		*tp,
 		  struct xfs_attri_log_item	*attrip)
 {