linux-kernel - Re: [PATCH v2] i2c: mpc: Poll for MCF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jul 2021 22:33:30 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] i2c: mpc: Poll for MCF

On Fri, Jul 16, 2021 at 08:58:32AM +1200, Chris Packham wrote:
> During some transfers the bus can still be busy when an interrupt is
> received. Commit 763778cd7926 ("i2c: mpc: Restore reread of I2C status
> register") attempted to address this by re-reading MPC_I2C_SR once but
> that just made it less likely to happen without actually preventing it.
> Instead of a single re-read, poll with a timeout so that the bus is given
> enough time to settle but a genuine stuck SCL is still noticed.
> 
> Fixes: 1538d82f4647 ("i2c: mpc: Interrupt driven transfer")
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Applied to for-current, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)