linux-kernel - Re: [PATCH 5.10 147/243] NFSD: Fix TP_printk() format specifier in nfsd_clid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210720214847.GB704@amd>
Date:   Tue, 20 Jul 2021 23:48:47 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        David Wysochanski <dwysocha@...hat.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        "J. Bruce Fields" <bfields@...hat.com>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.10 147/243] NFSD: Fix TP_printk() format specifier in
 nfsd_clid_class

Hi!

> [ Upstream commit a948b1142cae66785521a389cab2cce74069b547 ]
> 
> Since commit 9a6944fee68e ("tracing: Add a verifier to check string
> pointers for trace events"), which was merged in v5.13-rc1,
> TP_printk() no longer tacitly supports the "%.*s" format specifier.
> 
> These are low value tracepoints, so just remove them.

So I understand we want this for mainline, but AFAICT 5.10 does not
have 9a6944fee68e ("tracing: Add a verifier to check string pointers
for trace events") commit, so this does not fix any bug and removal of
tracepoints can be surprising.

Best regards,
								Pavel
								
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)