linux-kernel - Re: [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 21 Jul 2021 04:38:08 +0530
From:   "Mukunda,Vijendar" <vijendar.mukunda@....com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        broonie@...nel.org, alsa-devel@...a-project.org
Cc:     Sunil-kumar.Dommati@....com,
        open list <linux-kernel@...r.kernel.org>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>, Alexander.Deucher@....com,
        krisman@...labora.com
Subject: Re: [PATCH v4 09/12] ASoC: amd: add vangogh i2s dai driver ops

On 7/21/21 12:00 AM, Pierre-Louis Bossart wrote:
> 
>> diff --git a/sound/soc/amd/vangogh/acp5x.h b/sound/soc/amd/vangogh/acp5x.h
>> index 2300e63534e7..c94ed8795b9c 100644
>> --- a/sound/soc/amd/vangogh/acp5x.h
>> +++ b/sound/soc/amd/vangogh/acp5x.h
>> @@ -74,9 +74,20 @@
>>  #define I2S_MASTER_MODE_ENABLE 0x01
>>  #define I2S_MASTER_MODE_DISABLE 0x00
>>  
>> +#define SLOT_WIDTH_8 0x08
>> +#define SLOT_WIDTH_16 0x10
>> +#define SLOT_WIDTH_24 0x18
>> +#define SLOT_WIDTH_32 0x20
> 
> nit-pick: it's not incorrect but is the hex notation necessary?

Will fix it and post the new version

> 
>> +#define TDM_ENABLE 1
>> +#define TDM_DISABLE 0
>> +#define ACP5x_ITER_IRER_SAMP_LEN_MASK	0x38