linux-kernel - Re: [PATCH] virtio-balloon: Use virtio_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jul 2021 10:41:03 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     tianxianting <xianting.tian@...ux.alibaba.com>,
        Xianting Tian <xianting_tian@....com>, mst@...hat.com,
        david@...hat.com
Cc:     virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper


在 2021/7/19 下午12:22, tianxianting 写道:
> thanks,
>
> I checked, actually all virtio drivers have switched to use the helper 
> after this one merged.


Ok. Cool.

Thanks


>
> 在 2021/7/19 上午11:46, Jason Wang 写道:
>>
>> 在 2021/7/16 下午8:46, tianxianting 写道:
>>> Do you interest in this patch? just little improvment:)
>>>
>>> 在 2021/7/13 下午11:38, Xianting Tian 写道:
>>>> From: Xianting Tian <xianting.tian@...ux.alibaba.com>
>>>>
>>>> Use the helper virtio_find_vqs().
>>>>
>>>> Signed-off-by: Xianting Tian <xianting.tian@...ux.alibaba.com>
>>>> ---
>>>>   drivers/virtio/virtio_balloon.c | 4 ++--
>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/virtio/virtio_balloon.c 
>>>> b/drivers/virtio/virtio_balloon.c
>>>> index 510e931..18e0bf3 100644
>>>> --- a/drivers/virtio/virtio_balloon.c
>>>> +++ b/drivers/virtio/virtio_balloon.c
>>>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb)
>>>>           callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack;
>>>>       }
>>>>   -    err = vb->vdev->config->find_vqs(vb->vdev, 
>>>> VIRTIO_BALLOON_VQ_MAX,
>>>> -                     vqs, callbacks, names, NULL, NULL);
>>>> +    err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs,
>>>> +                callbacks, names, NULL);
>>>>       if (err)
>>>>           return err;
>>>
>>
>> Acked-by: Jason Wang <jasowang@...hat.com>
>>
>> Maybe it's better to convert all the drivers that doesn't use 
>> virtio_find_vqs{_ctx}.
>>
>> Thanks
>