linux-kernel - Re: [PATCH] vdpa/vdpa_sim: Use the negotiated features when calling vringh_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210720051633.GA245424@mtl-vdi-166.wap.labs.mlnx>
Date:   Tue, 20 Jul 2021 08:16:33 +0300
From:   Eli Cohen <elic@...dia.com>
To:     Jason Wang <jasowang@...hat.com>
CC:     <mst@...hat.com>, <sgarzare@...hat.com>,
        <virtualization@...ts.linux-foundation.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] vdpa/vdpa_sim: Use the negotiated features when calling
 vringh_init_iotlb

On Tue, Jul 20, 2021 at 11:13:00AM +0800, Jason Wang wrote:
> 
> 在 2021/7/19 下午9:44, Eli Cohen 写道:
> > When calling vringh_init_iotlb(), use the negotiated features which
> > might be different than the supported features.
> > 
> > Fixes: 011c35bac5ef ("vdpa_sim: add supported_features field in vdpasim_dev_attr)
> 
> 
> As Stefano said.
> 
> It should be 2c53d0f64c06f ("vdpasim: vDPA device simulator")

Makes sense. Though I haven't got Stefano's message.
I will post another one.

> 
> Other than this
> 
> Acked-by: Jason Wang <jasowang@...hat.com>
> 
> 
> > Signed-off-by: Eli Cohen <elic@...dia.com>
> > ---
> >   drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > index 14e024de5cbf..89a474c7a096 100644
> > --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> > @@ -66,7 +66,7 @@ static void vdpasim_queue_ready(struct vdpasim *vdpasim, unsigned int idx)
> >   {
> >   	struct vdpasim_virtqueue *vq = &vdpasim->vqs[idx];
> > -	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> > +	vringh_init_iotlb(&vq->vring, vdpasim->features,
> >   			  VDPASIM_QUEUE_MAX, false,
> >   			  (struct vring_desc *)(uintptr_t)vq->desc_addr,
> >   			  (struct vring_avail *)
> > @@ -86,7 +86,7 @@ static void vdpasim_vq_reset(struct vdpasim *vdpasim,
> >   	vq->device_addr = 0;
> >   	vq->cb = NULL;
> >   	vq->private = NULL;
> > -	vringh_init_iotlb(&vq->vring, vdpasim->dev_attr.supported_features,
> > +	vringh_init_iotlb(&vq->vring, vdpasim->features,
> >   			  VDPASIM_QUEUE_MAX, false, NULL, NULL, NULL);
> >   	vq->vring.notify = NULL;
>