linux-kernel - Re: [PATCH] clk: imx8: Unified initcall function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YPaGKokUH9nqQ6to@ryzen>
Date:   Tue, 20 Jul 2021 11:15:38 +0300
From:   Abel Vesa <abel.vesa@....com>
To:     Rudy Lo <luhuadong@....com>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: imx8: Unified initcall function

On 21-07-08 16:15:42, Rudy Lo wrote:
> It is better to use builtin_platform_driver initcall for clk driver
> rather then module_platform_driver, refer to clk-imx8qxp.c file.
> 

NAK for now. I think this would break GKI.

> Signed-off-by: Rudy Lo <luhuadong@....com>
> ---
>  drivers/clk/imx/clk-imx8mm.c | 2 +-
>  drivers/clk/imx/clk-imx8mn.c | 2 +-
>  drivers/clk/imx/clk-imx8mp.c | 2 +-
>  drivers/clk/imx/clk-imx8mq.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/clk/imx/clk-imx8mm.c b/drivers/clk/imx/clk-imx8mm.c
> index f1919fafb124..fa20b08e64f1 100644
> --- a/drivers/clk/imx/clk-imx8mm.c
> +++ b/drivers/clk/imx/clk-imx8mm.c
> @@ -654,7 +654,7 @@ static struct platform_driver imx8mm_clk_driver = {
>  		.of_match_table = imx8mm_clk_of_match,
>  	},
>  };
> -module_platform_driver(imx8mm_clk_driver);
> +builtin_platform_driver(imx8mm_clk_driver);
>  
>  MODULE_AUTHOR("Bai Ping <ping.bai@....com>");
>  MODULE_DESCRIPTION("NXP i.MX8MM clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 88f6630cd472..67b9ded112e4 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -605,7 +605,7 @@ static struct platform_driver imx8mn_clk_driver = {
>  		.of_match_table = imx8mn_clk_of_match,
>  	},
>  };
> -module_platform_driver(imx8mn_clk_driver);
> +builtin_platform_driver(imx8mn_clk_driver);
>  
>  MODULE_AUTHOR("Anson Huang <Anson.Huang@....com>");
>  MODULE_DESCRIPTION("NXP i.MX8MN clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c
> index 12837304545d..cdb40e61cef0 100644
> --- a/drivers/clk/imx/clk-imx8mp.c
> +++ b/drivers/clk/imx/clk-imx8mp.c
> @@ -735,7 +735,7 @@ static struct platform_driver imx8mp_clk_driver = {
>  		.of_match_table = imx8mp_clk_of_match,
>  	},
>  };
> -module_platform_driver(imx8mp_clk_driver);
> +builtin_platform_driver(imx8mp_clk_driver);
>  
>  MODULE_AUTHOR("Anson Huang <Anson.Huang@....com>");
>  MODULE_DESCRIPTION("NXP i.MX8MP clock driver");
> diff --git a/drivers/clk/imx/clk-imx8mq.c b/drivers/clk/imx/clk-imx8mq.c
> index c491bc9c61ce..54f17de30935 100644
> --- a/drivers/clk/imx/clk-imx8mq.c
> +++ b/drivers/clk/imx/clk-imx8mq.c
> @@ -630,7 +630,7 @@ static struct platform_driver imx8mq_clk_driver = {
>  		.of_match_table = imx8mq_clk_of_match,
>  	},
>  };
> -module_platform_driver(imx8mq_clk_driver);
> +builtin_platform_driver(imx8mq_clk_driver);
>  
>  MODULE_AUTHOR("Abel Vesa <abel.vesa@....com>");
>  MODULE_DESCRIPTION("NXP i.MX8MQ clock driver");
> -- 
> 2.25.1
> 
>