linux-kernel - Re: [PATCH] Revert "qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jul 2021 13:05:54 +0200
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jia He <justin.he@....com>
Cc:     Ariel Elior <aelior@...vell.com>, GR-everest-linux-l2@...vell.com,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, nd@....com,
        Prabhakar Kushwaha <pkushwaha@...vell.com>
Subject: Re: [PATCH] Revert "qed: fix possible unpaired spin_{un}lock_bh in
 _qed_mcp_cmd_and_union()"

On Tue, 20 Jul 2021 17:27:39 +0800, Jia He wrote:
> This reverts commit 2d2f5ded858a4f4659fc63e01dd55605598a8f05.

The hash looks wrong, the patch was applied to netdev/net AFAICT,
and the ref there is: 6206b7981a36 ("qed: fix possible unpaired
spin_{un}lock_bh in _qed_mcp_cmd_and_union()")

Please tag the subject with "net":

[PATCH net] Revert ...

> That patch added additional spin_{un}lock_bh(), which was harmless
> but pointless. The orginal code path has guaranteed the pair of
> spin_{un}lock_bh().
> 
> We'd better revert it before we find the exact root cause of the
> bug_on mentioned in that patch.
> 
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Prabhakar Kushwaha <pkushwaha@...vell.com>
> Signed-off-by: Jia He <justin.he@....com>

Please also add a Fixes tag.

Fixes: 6206b7981a36 ("qed: fix possible unpaired spin_{un}lock_bh in _qed_mcp_cmd_and_union()")