linux-kernel - Re: [PATCH] PCI: endpoint: Use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 20 Jul 2021 10:08:51 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Sasha Levin <sashal@...nel.org>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: endpoint: Use sysfs_emit() in "show" functions

Hi Krzysztof,

On 2021/07/20 0:18, Krzysztof Wilczy?ski wrote:
 > [+cc Sasha for visibility]
 >
 > Hi!
 >
 > [...]
 >>> Nice catch!
 >>
 >> I actually executed "cat" against configfs to meet the issue and found
 >> your solution in pci-sysfs.
 >
 > Oh!  That's not good...  I am curious, which attribute caused this?

Sorry I misunderstood.

I found this "cat" issue on next-20210713 and all configfs attribues had
the same issue.

However, my patch wasn't the solution for the issue. This has been fixed by
7fe1e79b59ba ("configfs: implement the .read_iter and .write_iter methods").

The function replacement was found in the process of finding the issue.

 > Also, if this is fixing a bug, then it might warrant letting the folks who look
 > after the long-term and stable kernels know.  I also wonder if there would be
 > something to add for the "Fixes:" tag, if there is a previous commit this
 > change fixes.

So my patch doesn't fix any issues.

Thank you,

---
Best Regards
Kunihiko Hayashi