linux-kernel - Re: [PATCH v3 2/3] ima: Return int in the functions to measure a buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <999c3297f71e5f7d69b555bc8c999729e8b1ae31.camel@linux.ibm.com>
Date:   Tue, 20 Jul 2021 09:01:50 -0400
From:   Mimi Zohar <zohar@...ux.ibm.com>
To:     Roberto Sassu <roberto.sassu@...wei.com>,
        "paul@...l-moore.com" <paul@...l-moore.com>
Cc:     "stephen.smalley.work@...il.com" <stephen.smalley.work@...il.com>,
        "prsriva02@...il.com" <prsriva02@...il.com>,
        "tusharsu@...ux.microsoft.com" <tusharsu@...ux.microsoft.com>,
        "nramas@...ux.microsoft.com" <nramas@...ux.microsoft.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "selinux@...r.kernel.org" <selinux@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] ima: Return int in the functions to measure a
 buffer

On Tue, 2021-07-20 at 12:38 +0000, Roberto Sassu wrote:
> > > This patch modifies the return type from void to int, and returns 0 if the
> > > buffer has been successfully measured, a negative value otherwise.
> > 
> > Needed here is an explanation as to why ima_measure_critical_data() is
> > special.
> 
> We don't want to unnecessarily calculate the digest twice.

That's what the "iint" cache is for.  .  This needs more a of an
explaintion as to why  ima_measure_critical_data() is special.

thanks,

Mimi