linux-kernel - Re: [PATCH v5 1/1] lib: Convert UUID runtime test to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFd5g47nOfQ506ZyivLy2U1FkrnNhuDxUr0wUyN=F700mw+N8A@mail.gmail.com>
Date:   Wed, 21 Jul 2021 12:52:52 -0700
From:   Brendan Higgins <brendanhiggins@...gle.com>
To:     André Almeida <andrealmeid@...labora.com>
Cc:     Christoph Hellwig <hch@....de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        kunit-dev@...glegroups.com, Shuah Khan <shuah@...nel.org>,
        ~lkcamp/patches@...ts.sr.ht, nfraprado@...labora.com,
        leandro.ribeiro@...labora.com,
        Vitor Massaru Iha <vitor@...saru.org>, lucmaga@...il.com,
        David Gow <davidgow@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>, tales.aparecida@...il.com
Subject: Re: [PATCH v5 1/1] lib: Convert UUID runtime test to KUnit

On Sat, Jul 17, 2021 at 4:48 PM André Almeida <andrealmeid@...labora.com> wrote:
>
> Remove custom functions for testing and use KUnit framework. Keep the
> tested functions and test data the same.
>
> Current test threat (g/u)uid_parse and (g/u)uid_equal as different test
> cases. Make both functions being part of the same test case, given the
> dependency regarding their results. This reduces the tests cases from 6
> cases to 4, while keeping the test coverage the same. Given that we have
> 3 strings for each test case, current test output notifies 18 tests
> results, and the KUnit output announces 12 results.
>
> Signed-off-by: André Almeida <andrealmeid@...labora.com>
> Reviewed-by: Daniel Latypov <dlatypov@...gle.com>

I don't think I have anything to add that hasn't already been said.
Nevertheless, this looks good to me.

Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com>