linux-kernel - Re: [PATCH v3 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202107220431.yxFduKDb-lkp@intel.com>
Date:   Thu, 22 Jul 2021 04:34:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Magnus Damm <magnus.damm@...il.com>,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>,
        Biju Das <biju.das.jz@...renesas.com>
Subject: Re: [PATCH v3 2/4] pinctrl: renesas: Add RZ/G2L pin and gpio
 controller driver

Hi Lad,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on 2734d6c1b1a089fb593ef6a23d4b70903526fe0c]

url:    https://github.com/0day-ci/linux/commits/Lad-Prabhakar/pin-and-gpio-controller-driver-for-Renesas-RZ-G2L/20210722-031725
base:   2734d6c1b1a089fb593ef6a23d4b70903526fe0c
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/8735b74e6bbde5d76a49d014d4d1e1d901f7f370
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Lad-Prabhakar/pin-and-gpio-controller-driver-for-Renesas-RZ-G2L/20210722-031725
        git checkout 8735b74e6bbde5d76a49d014d4d1e1d901f7f370
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/pinctrl/renesas/pinctrl-rzg2l.c: In function 'rzg2l_pinctrl_set_mux':
>> drivers/pinctrl/renesas/pinctrl-rzg2l.c:185:16: warning: variable 'data' set but not used [-Wunused-but-set-variable]
     185 |  unsigned long data;
         |                ^~~~


vim +/data +185 drivers/pinctrl/renesas/pinctrl-rzg2l.c

   176	
   177	static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev,
   178					 unsigned int func_selector,
   179					 unsigned int group_selector)
   180	{
   181		struct rzg2l_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
   182		struct function_desc *func;
   183		unsigned int i, *psel_val;
   184		struct group_desc *group;
 > 185		unsigned long data;
   186		int *pins;
   187	
   188		func = pinmux_generic_get_function(pctldev, func_selector);
   189		if (!func)
   190			return -EINVAL;
   191		group = pinctrl_generic_get_group(pctldev, group_selector);
   192		if (!group)
   193			return -EINVAL;
   194	
   195		psel_val = func->data;
   196		pins = group->pins;
   197		data = (unsigned long)group->data;
   198	
   199		for (i = 0; i < group->num_pins; i++) {
   200			dev_dbg(pctrl->dev, "port:%u pin: %u PSEL:%u\n",
   201				RZG2L_PIN_ID_TO_PORT(pins[i]), RZG2L_PIN_ID_TO_PIN(pins[i]),
   202				psel_val[i]);
   203			rzg2l_pinctrl_set_pfc_mode(pctrl, RZG2L_PIN_ID_TO_PORT(pins[i]),
   204						   RZG2L_PIN_ID_TO_PIN(pins[i]), psel_val[i]);
   205		}
   206	
   207		return 0;
   208	};
   209	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (60078 bytes)