linux-kernel - Re: [PATCH] A reset can be sent anytime and so the vhcd Root Hub should renable the port always on a virtual reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YPepoOjwX9WSjJYG@kroah.com>
Date:   Wed, 21 Jul 2021 06:59:12 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Michael Broadfoot <msbroadf@...il.com>
Cc:     valentina.manea.m@...il.com, shuah@...nel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] A reset can be sent anytime and so the vhcd Root Hub
 should renable the port always on a virtual reset

On Wed, Jul 21, 2021 at 11:15:02AM +1000, Michael Broadfoot wrote:
> And if the HIGH and LOW flags are not set on the port
> status that means FULL speed and is not an
> error (see 11.24.2.7.1 Port Status Bits)
> ---
>  drivers/usb/usbip/vhci_hcd.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 4ba6bcdaa8e9..3ea76dcdc8e2 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -455,15 +455,12 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>  			vhci_hcd->port_status[rhport] &= ~(1 << USB_PORT_FEAT_RESET);
>  			vhci_hcd->re_timeout = 0;
>  
> -			if (vhci_hcd->vdev[rhport].ud.status ==
> -			    VDEV_ST_NOTASSIGNED) {
>  				usbip_dbg_vhci_rh(
>  					" enable rhport %d (status %u)\n",
>  					rhport,
>  					vhci_hcd->vdev[rhport].ud.status);
>  				vhci_hcd->port_status[rhport] |=
>  					USB_PORT_STAT_ENABLE;
> -			}
>  
>  			if (hcd->speed < HCD_USB3) {
>  				switch (vhci_hcd->vdev[rhport].speed) {
> @@ -475,8 +472,7 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 typeReq, u16 wValue,
>  					vhci_hcd->port_status[rhport] |=
>  						USB_PORT_STAT_LOW_SPEED;
>  					break;
> -				default:
> -					pr_err("vhci_device speed not set\n");
> +				default: // FULL speed
>  					break;
>  				}
>  			}
> -- 
> 2.30.2
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/SubmittingPatches and resend it after
  adding that line.  Note, the line needs to be in the body of the
  email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what is needed in order to
  properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/SubmittingPatches for what a proper Subject: line should
  look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot