linux-kernel - Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPfFn2Qlaoe5cwBX@unreal>
Date:   Wed, 21 Jul 2021 09:58:39 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...dia.com>, linux-kernel@...r.kernel.org,
        linux-rdma@...r.kernel.org, Mark Zhang <markz@...lanox.com>
Subject: Re: [PATCH rdma-next 4/7] RDMA/core: Reorganize create QP low-level
 functions

On Wed, Jul 21, 2021 at 07:45:48AM +0100, Christoph Hellwig wrote:
> > +/**
> > + * ib_create_qp_kernel - Creates a kernel QP associated with the specified
> 
> Any reason this function is renamed?  This seems rather unrelated to
> the rest of th patch.

I wanted to make two functions: ib_create_qp_kernel and ib_create_qp_user.

> 
> > + *   protection domain.
> >   * @pd: The protection domain associated with the QP.
> >   * @qp_init_attr: A list of initial attributes required to create the
> >   *   QP.  If QP creation succeeds, then the attributes are updated to
> >   *   the actual capabilities of the created QP.
> >   * @caller: caller's build-time module name
> > - *
> > - * NOTE: for user qp use ib_create_qp_user with valid udata!
> >   */
> 
> Also a kerneldoc comment for a function that is an implementation
> detail is actively harmful.  Please document ib_create_qp instead.

Sure, will do.