linux-kernel - Re: [PATCH resend] staging: rtl8188eu: move all source files from core subdirectory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPfXzlmYk4EPap+F@kroah.com>
Date:   Wed, 21 Jul 2021 10:16:14 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     Larry.Finger@...inger.net, dan.carpenter@...cle.com,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH resend] staging: rtl8188eu: move all source files from
 core subdirectory

On Mon, Jul 19, 2021 at 11:46:01PM +0100, Phillip Potter wrote:
> Move all C source files from the core subdirectory to the root
> folder of the driver, and adjust Makefile accordingly. The ultmate
> goal is to remove hal layer and fold its functionalty into the main
> sources. At this point, the distinction between hal and core will be
> meaningless, so this is the first step towards simplifying the file
> layout.
> 
> Signed-off-by: Phillip Potter <phil@...lpotter.co.uk>
> ---
>  drivers/staging/rtl8188eu/Makefile            | 34 +++++++++----------
>  drivers/staging/rtl8188eu/{core => }/rtw_ap.c |  0

<snip>

As others have pointed out, let's move files when they need to be moved,
not yet.  Removing the HAL layer is great here, but when that happens,
the hal/ directory will be empty and we can go from there if things
still need to be moved.

thanks,

greg k-h