linux-kernel - Re: [PATCH REPOST] TDA1997x: replace video detection routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99ca51b7-804e-1a53-765c-013093d38598@xs4all.nl>
Date:   Wed, 21 Jul 2021 12:04:26 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Krzysztof Hałasa <khalasa@...p.pl>
Cc:     Tim Harvey <tharvey@...eworks.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH REPOST] TDA1997x: replace video detection routine

On 21/07/2021 09:56, Krzysztof Hałasa wrote:
> Hi Hans,
> 
> Hans Verkuil <hverkuil@...all.nl> writes:
> 
>>> --- a/drivers/media/i2c/tda1997x.c
>>> +++ b/drivers/media/i2c/tda1997x.c
>>> @@ -1092,66 +1094,71 @@ tda1997x_detect_std(struct tda1997x_state *state,
>>>  		    struct v4l2_dv_timings *timings)
> 
> ...
> 
>>> +	if (!timings)
>>> +		return 0;
>>
>> This check isn't necessary, timings is never NULL.
> 
> Well, the tda1997x_irq_sus() does this:
> 
> 	if (debug)
> 		tda1997x_detect_std(state, NULL);

Ah, I missed that. Then you can keep that check.

Regards,

	Hans

> 
> Perhaps there is a better way, but I think I will leave it for now.
> Also there is the issue of ignoring tda1997x_detect_std() return value,
> but I can now see it's only a case in tda1997x_query_dv_timings(), easy
> to fix.
> 
> Will post an update shortly.
> 
> Thanks for your comments,
>