lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 21 Jul 2021 13:34:33 +0200 From: "Fabio M. De Francesco" <fmdefrancesco@...il.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Larry Finger <Larry.Finger@...inger.net>, Dan Carpenter <dan.carpenter@...cle.com>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] staging: rtl8188eu: Remove an unused variable and some lines of code On Wednesday, July 21, 2021 10:19:33 AM CEST Greg Kroah-Hartman wrote: > On Mon, Jul 05, 2021 at 03:41:51PM +0200, Fabio M. De Francesco wrote: > > Remove set but unused iw_operation_mode[]. This driver doesn't support > > SIOCSIWRATE. It just returns zero and does nothing. Change it to > > return -ENOTSUPP instead. (This is an API change but we don't expect it > > to break anything). > > > > Suggested-by: Dan Carpenter <dan.carpenter@...cle.com> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com> > > --- > > > > v1->v2: Delete rtw_wx_set_rate() and its association with command > > SIOCSIWRATE as suggested by Dan Carpenter <dan.carpenter@...cle.com> > > Does not apply to my tree :( > Hi Greg, It cannot apply to your tree because, while it was waiting for acceptance, someone else did a large part of the removal of the code related to the unsupported SIOCSIWRATE and you applied this other patch. However, the no more necessary iw_operation_mode[] is still in your tree. So I'm about to send a patch that only removes the above-mentioned array. Thanks, Fabio
Powered by blists - more mailing lists