linux-kernel - Re: [PATCH] Documentation: gpio: driver.rst: Remove gpiochip_irqchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJVSSsRM1W957E-urQqbY1PB+wQ6sRCRnCaHVKg6ge13ZA@mail.gmail.com>
Date:   Wed, 21 Jul 2021 15:18:14 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Vincent Pelletier <plr.vincent@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        linux-doc <linux-doc@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation: gpio: driver.rst: Remove
 gpiochip_irqchip_add mention

On Mon, Jul 5, 2021 at 2:44 AM Vincent Pelletier <plr.vincent@...il.com> wrote:
>
> This function was removed in commit f1f37abbe6fc ("gpio: Retire the
> explicit gpio irqchip code") but this mention was left behind.
> Also, mention that .set_type() only has to set a line handler if the chip
> is cascaded, as opposed to hierarchical.
>
> Signed-off-by: Vincent Pelletier <plr.vincent@...il.com>
> ---
>  Documentation/driver-api/gpio/driver.rst | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/driver-api/gpio/driver.rst b/Documentation/driver-api/gpio/driver.rst
> index d6b0d779859b..bbc53920d4dd 100644
> --- a/Documentation/driver-api/gpio/driver.rst
> +++ b/Documentation/driver-api/gpio/driver.rst
> @@ -547,13 +547,10 @@ To use the helpers please keep the following in mind:
>    the irqchip can initialize. E.g. .dev and .can_sleep shall be set up
>    properly.
>
> -- Nominally set all handlers to handle_bad_irq() in the setup call and pass
> -  handle_bad_irq() as flow handler parameter in gpiochip_irqchip_add() if it is
> -  expected for GPIO driver that irqchip .set_type() callback will be called
> -  before using/enabling each GPIO IRQ. Then set the handler to
> -  handle_level_irq() and/or handle_edge_irq() in the irqchip .set_type()
> -  callback depending on what your controller supports and what is requested
> -  by the consumer.
> +- Nominally set gpio_irq_chip.handler to handle_bad_irq. Then, if your irqchip
> +  is cascaded, set the handler to handle_level_irq() and/or handle_edge_irq()
> +  in the irqchip .set_type() callback depending on what your controller
> +  supports and what is requested by the consumer.
>
>
>  Locking IRQ usage
> --
> 2.32.0
>

Patch applied, thanks!

Bartosz