linux-kernel - Re: [PATCH] kernfs: Convert from atomic_t to refcount_t on kernfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YPg+9MGnEOxj9PB3@kroah.com>
Date:   Wed, 21 Jul 2021 17:36:20 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>
Cc:     Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org,
        yuanxzhang@...an.edu.cn, Xin Tan <tanxin.ctf@...il.com>
Subject: Re: [PATCH] kernfs: Convert from atomic_t to refcount_t on
 kernfs_node->count

On Mon, Jul 19, 2021 at 04:33:21PM +0800, Xiyu Yang wrote:
> refcount_t type and corresponding API can protect refcounters from
> accidental underflow and overflow and further use-after-free situations.

But this really is a count, not a refcount.

So are you _sure_ this should be changed?

What did you to do to test this?

thanks,

greg k-h