linux-kernel - Re: [PATCH v7 24/37] soc/tegra: fuse: Enable fuse clock on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4549652-ab18-7b69-c684-b25ecab223bf@gmail.com>
Date:   Wed, 21 Jul 2021 19:00:45 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>
Cc:     linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-pm@...r.kernel.org, Viresh Kumar <vireshk@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v7 24/37] soc/tegra: fuse: Enable fuse clock on suspend

02.07.2021 02:27, Dmitry Osipenko пишет:
> +static int __maybe_unused tegra_fuse_resume(struct device *dev)
> +{
> +	int err;
> +
> +	/*
> +	 * Critical for RAM re-repair operation, which must occur on resume
> +	 * from LP1 system suspend and as part of CCPLEX cluster switching.
> +	 */
> +	if (fuse->soc->clk_suspend_on) {
> +		err = pm_runtime_force_resume(dev);
> +		if (err)
> +			return err;
> +	}
> +
> +	return 0;
> +}
> +
> +static int __maybe_unused tegra_fuse_suspend(struct device *dev)
> +{
> +	int err;
> +
> +	if (fuse->soc->clk_suspend_on) {
> +		err = pm_runtime_force_suspend(dev);
> +		if (err)
> +			return err;
> +	}

I just noticed that something gone wrong with this patch, the condition
should have been inverted. I'll fix it in the next version.

I may also try to factor out these fuse and some other patches which
could become a 5.15 material.