linux-kernel - Re: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot modem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Jul 2021 23:11:35 +0530
From:   Sibi Sankar <sibis@...eaurora.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     bjorn.andersson@...aro.org, mka@...omium.org, robh+dt@...nel.org,
        saiprakash.ranjan@...eaurora.org, will@...nel.org, ohad@...ery.com,
        agross@...nel.org, mathieu.poirier@...aro.org,
        robin.murphy@....com, joro@...tes.org, p.zabel@...gutronix.de,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, evgreen@...omium.org,
        dianders@...omium.org
Subject: Re: [PATCH v2 08/10] arm64: dts: qcom: sc7280: Add nodes to boot
 modem

On 2021-07-21 11:14, Stephen Boyd wrote:
> Quoting Sibi Sankar (2021-07-20 03:12:58)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi 
>> b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 5ed7a511bfc9..3fb6a6ef39f8 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -1219,6 +1224,21 @@
>>                         };
>>                 };
>> 
>> +               imem@...aa000 {
> 
> is sram a more appropriate node name here? Is imem a generic node name
> in DT spec?

binding check for qcom,pil-info.yaml
didn't complain so I just followed
it. AFAICS, sram isn't mentioned in
generic node names either.

> 
>> +                       compatible = "syscon", "simple-mfd";
>> +                       reg = <0 0x146aa000 0 0x2000>;
>> +
>> +                       #address-cells = <2>;
>> +                       #size-cells = <2>;
>> +
>> +                       ranges = <0 0x0 0 0x146aa000 0 0x2000>;
>> +
>> +                       pil-reloc@94c {
>> +                               compatible = "qcom,pil-reloc-info";
>> +                               reg = <0 0x94c 0 0xc8>;
>> +                       };
>> +               };
>> +

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.