linux-kernel - Re: [PATCH] lib/string: Bring optimized memcmp from glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whhThPq-ETzyepM0OteV480FcVExxPMoU0ntaH-mX_BrQ@mail.gmail.com>
Date:   Wed, 21 Jul 2021 11:55:50 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Nikolay Borisov <nborisov@...e.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH] lib/string: Bring optimized memcmp from glibc

On Wed, Jul 21, 2021 at 11:45 AM Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
>  - the code generation is actually quite good with both gcc and clang.

Side note: I only looked at whether the code looked good, I didn't
check whether it looked *correct*.

So caveat emptor.  It looks trivially correct both on the source and
assembly level, but it's entirely untested, which probably means that
it has some stupid bug.

               Linus