linux-kernel - Re: [PATCH] staging: rtl8188eu: Line over 100 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPmhA3JbzlwE66NL@kroah.com>
Date:   Thu, 22 Jul 2021 18:46:59 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jignesh Patel <jigs0101@...il.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Guenter Roeck <linux@...ck-us.net>,
        Martin Kaiser <martin@...ser.cx>,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Ivan Safonov <insafonov@...il.com>,
        Paul McQuade <paulmcquad@...il.com>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: Line over 100 characters

On Thu, Jul 22, 2021 at 10:11:37PM +0530, Jignesh Patel wrote:
> Break various lines into multiple lines to respect 100 character width limit.
> Reported by checkpatch.pl
> 
> Signed-off-by: Jignesh Patel <jigs0101@...il.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_ap.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers/staging/rtl8188eu/core/rtw_ap.c
> index b817aa8b9de4..b83d6da01b7c 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_ap.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_ap.c
> @@ -254,9 +254,12 @@ void expire_timeout_chk(struct adapter *padapter)
>  			updated = ap_free_sta(padapter, psta, true,
>  					      WLAN_REASON_DEAUTH_LEAVING);
>  		} else {
> -			/* TODO: Aging mechanism to digest frames in sleep_q to avoid running out of xmitframe */
> +			/** TODO: Aging mechanism to digest frames in

Does this line look correct now?

Please look at how comments are formatted...

thanks,

greg k-h