linux-kernel - Re: [PATCH] memory: tegra: fix unused-function warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84920cc2-f5ba-133b-8b2c-f7d2c69eaad3@nvidia.com>
Date:   Thu, 22 Jul 2021 18:22:57 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Thierry Reding <thierry.reding@...il.com>
CC:     Arnd Bergmann <arnd@...db.de>, <linux-kernel@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] memory: tegra: fix unused-function warning


On 22/07/2021 10:07, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The tegra186_mc_client_sid_override() is only called from
> an #ifdef block:
> 
> drivers/memory/tegra/tegra186.c:74:13: error: 'tegra186_mc_client_sid_override' defined but not used [-Werror=unused-function]
>    74 | static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
>       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Add another #ifdef around the called function.
> 
> Fixes: 393d66fd2cac ("memory: tegra: Implement SID override programming")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/memory/tegra/tegra186.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/memory/tegra/tegra186.c b/drivers/memory/tegra/tegra186.c
> index e65eac5764d4..3d153881abc1 100644
> --- a/drivers/memory/tegra/tegra186.c
> +++ b/drivers/memory/tegra/tegra186.c
> @@ -71,6 +71,7 @@ static int tegra186_mc_resume(struct tegra_mc *mc)
>  	return 0;
>  }
>  
> +#if IS_ENABLED(CONFIG_IOMMU_API)
>  static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
>  					    const struct tegra_mc_client *client,
>  					    unsigned int sid)
> @@ -108,6 +109,7 @@ static void tegra186_mc_client_sid_override(struct tegra_mc *mc,
>  		writel(sid, mc->regs + client->regs.sid.override);
>  	}
>  }
> +#endif
>  
>  static int tegra186_mc_probe_device(struct tegra_mc *mc, struct device *dev)
>  {
> 


Acked-by: Jon Hunter <jonathanh@...dia.com>

Thanks for fixing!

Jon

-- 
nvpublic