linux-kernel - Re: [GIT PULL] Hyper-V fixes for 5.14-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wirFvNqAvaNaABHc2mi7FKL4n6TEAwQ3WTyTJueJcHCvA@mail.gmail.com>
Date:   Thu, 22 Jul 2021 10:25:46 -0700
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Wei Liu <wei.liu@...nel.org>
Cc:     Linux Kernel List <linux-kernel@...r.kernel.org>,
        Linux on Hyper-V List <linux-hyperv@...r.kernel.org>,
        kys@...rosoft.com, Stephen Hemminger <sthemmin@...rosoft.com>,
        haiyangz@...rosoft.com, decui@...rosoft.com,
        Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [GIT PULL] Hyper-V fixes for 5.14-rc3

On Thu, Jul 22, 2021 at 7:09 AM Wei Liu <wei.liu@...nel.org> wrote:
>
>   - Reversion of a bogus patch that went into 5.14-rc1

When doing a revert, please explain it.

Yes, they are simple in the sense that they just undo something, but
at the same time, that "something" was done for a reason, and the
reason why that original change was wrong, and how it was noticed (ie
what the symptoms of the reverted patch were) is important.

I've pulled this, so it's too late now, but please please please
explain reverts in the future, not just a "This reverts commit XYZ".

                     Linus