linux-kernel - [PATCH] arm64: audit: fix return value high 32bit truncation problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210722060707.531-1-weiyuchen3@huawei.com>
Date:   Thu, 22 Jul 2021 14:07:07 +0800
From:   Yuchen Wei <weiyuchen3@...wei.com>
To:     <catalin.marinas@....com>, <will@...nel.org>
CC:     <mark.rutland@....com>, <vincenzo.frascino@....com>,
        <keescook@...omium.org>, <pcc@...gle.com>, <weiyuchen3@...wei.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH] arm64: audit: fix return value high 32bit truncation problem

From: weiyuchen <weiyuchen3@...wei.com>

Add error code judgment in invoke_syscall() to prevent kernel
components such as audit and tracepoint from obtaining incorrect
return values. For example:

type=SYSCALL msg=audit(342.780:69): arch=40000028 syscall=235
success=yes exit=4294967235

The syscall return value is -61, but due to the following process in
invoke_syscall():

	if (is_compat_task())
		ret = lower_32_bits(ret);
	regs->regs[0] = ret;

The return value audit or tracepoint get from regs[0] is 4294967235,
which is an incorrect return value.

Signed-off-by: weiyuchen <weiyuchen3@...wei.com>
---
 arch/arm64/kernel/syscall.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kernel/syscall.c b/arch/arm64/kernel/syscall.c
index 263d6c1a525f..f9f042d9a088 100644
--- a/arch/arm64/kernel/syscall.c
+++ b/arch/arm64/kernel/syscall.c
@@ -54,7 +54,7 @@ static void invoke_syscall(struct pt_regs *regs, unsigned int scno,
 		ret = do_ni_syscall(regs, scno);
 	}
 
-	if (is_compat_task())
+	if (is_compat_task() && !IS_ERR_VALUE(ret))
 		ret = lower_32_bits(ret);
 
 	regs->regs[0] = ret;
-- 
2.12.3