lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 22 Jul 2021 10:45:55 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     kernel@...gutronix.de,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Alexandre Bounine <alex.bou9@...il.com>,
        Alex Dubov <oakad@...oo.com>, Alex Elder <elder@...nel.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Alison Schofield <alison.schofield@...el.com>,
        Allen Hubbe <allenbh@...il.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Andy Gross <agross@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Ben Widawsky <ben.widawsky@...el.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Bodo Stroesser <bostroesser@...il.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Chen-Yu Tsai <wens@...e.org>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        Cornelia Huck <cohuck@...hat.com>,
        Cristian Marussi <cristian.marussi@....com>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        David Woodhouse <dwmw@...zon.co.uk>,
        Dexuan Cui <decui@...rosoft.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Dominik Brodowski <linux@...inikbrodowski.net>,
        Eric Farman <farman@...ux.ibm.com>,
        Finn Thain <fthain@...ux-m68k.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Frank Li <lznuaa@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Geoff Levand <geoff@...radead.org>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Halil Pasic <pasic@...ux.ibm.com>,
        Hannes Reinecke <hare@...e.de>,
        Hans de Goede <hdegoede@...hat.com>,
        Harald Freudenberger <freude@...ux.ibm.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Helge Deller <deller@....de>, Ira Weiny <ira.weiny@...el.com>,
        Jakub Kicinski <kuba@...nel.org>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Jason Wang <jasowang@...hat.com>,
        Jens Taprogge <jens.taprogge@...rogge.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Joey Pabalan <jpabalanb@...il.com>,
        Johan Hovold <johan@...nel.org>,
        Johannes Berg <johannes@...solutions.net>,
        Johannes Thumshirn <morbidrsa@...il.com>,
        Jon Mason <jdmason@...zu.us>, Juergen Gross <jgross@...e.com>,
        Julien Grall <jgrall@...zon.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Kirti Wankhede <kwankhede@...dia.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Krzysztof Wilczyński <kw@...ux.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Lee Jones <lee.jones@...aro.org>, Len Brown <lenb@...nel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Manohar Vanga <manohar.vanga@...il.com>,
        Marc Zyngier <maz@...nel.org>, Mark Brown <broonie@...nel.org>,
        Mark Gross <mgross@...ux.intel.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Martyn Welch <martyn@...chs.me.uk>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Matthew Rosato <mjrosato@...ux.ibm.com>,
        Matt Porter <mporter@...nel.crashing.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Maximilian Luz <luzmaximilian@...il.com>,
        Maxim Levitsky <maximlevitsky@...il.com>,
        Michael Buesch <m@...s.ch>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michael Jamet <michael.jamet@...el.com>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Mike Christie <michael.christie@...cle.com>,
        Moritz Fischer <mdf@...nel.org>,
        Ohad Ben-Cohen <ohad@...ery.com>,
        Pali Rohár <pali@...nel.org>,
        Paul Mackerras <paulus@...ba.org>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Rafał Miłecki <zajec5@...il.com>,
        Rich Felker <dalias@...c.org>,
        Rikard Falkeborn <rikard.falkeborn@...il.com>,
        Rob Herring <robh@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
        Samuel Holland <samuel@...lland.org>,
        Samuel Iglesias Gonsalvez <siglesias@...lia.com>,
        SeongJae Park <sjpark@...zon.de>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Stefan Richter <stefanr@...6.in-berlin.de>,
        Stephen Boyd <sboyd@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Sudeep Holla <sudeep.holla@....com>,
        Sven Van Asbroeck <TheSven73@...il.com>,
        Takashi Iwai <tiwai@...e.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Thorsten Scherer <t.scherer@...elmann.de>,
        Tomas Winkler <tomas.winkler@...el.com>,
        Tom Rix <trix@...hat.com>,
        Tyrel Datwyler <tyreld@...ux.ibm.com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Vinod Koul <vkoul@...nel.org>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Wei Liu <wei.liu@...nel.org>,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Wolfram Sang <wsa@...nel.org>, Wu Hao <hao.wu@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        YueHaibing <yuehaibing@...wei.com>,
        Yufen Yu <yuyufen@...wei.com>, alsa-devel@...a-project.org,
        dmaengine@...r.kernel.org, greybus-dev@...ts.linaro.org,
        industrypack-devel@...ts.sourceforge.net, kvm@...r.kernel.org,
        linux1394-devel@...ts.sourceforge.net, linux-acpi@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-cxl@...r.kernel.org,
        linux-fpga@...r.kernel.org, linux-hyperv@...r.kernel.org,
        linux-i2c@...r.kernel.org, linux-i3c@...ts.infradead.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-media@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-mmc@...r.kernel.org,
        linux-ntb@...glegroups.com, linux-parisc@...r.kernel.org,
        linux-pci@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-remoteproc@...r.kernel.org, linux-s390@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-sh@...r.kernel.org, linux-spi@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-sunxi@...ts.linux.dev,
        linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, nvdimm@...ts.linux.dev,
        platform-driver-x86@...r.kernel.org, sparclinux@...r.kernel.org,
        target-devel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org,
        xen-devel@...ts.xenproject.org
Subject: Re: [PATCH v4 0/5] bus: Make remove callback return void

On Wed, Jul 21, 2021 at 12:09:41PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jul 13, 2021 at 09:35:17PM +0200, Uwe Kleine-König wrote:
> > Hello,
> > 
> > this is v4 of the final patch set for my effort to make struct
> > bus_type::remove return void.
> > 
> > The first four patches contain cleanups that make some of these
> > callbacks (more obviously) always return 0. They are acked by the
> > respective maintainers. Bjorn Helgaas explicitly asked to include the
> > pci patch (#1) into this series, so Greg taking this is fine. I assume
> > the s390 people are fine with Greg taking patches #2 to #4, too, they
> > didn't explicitly said so though.
> > 
> > The last patch actually changes the prototype and so touches quite some
> > drivers and has the potential to conflict with future developments, so I
> > consider it beneficial to put these patches into next soon. I expect
> > that it will be Greg who takes the complete series, he already confirmed
> > via irc (for v2) to look into this series.
> > 
> > The only change compared to v3 is in the fourth patch where I modified a
> > few more drivers to fix build failures. Some of them were found by build
> > bots (thanks!), some of them I found myself using a regular expression
> > search. The newly modified files are:
> > 
> >  arch/sparc/kernel/vio.c
> >  drivers/nubus/bus.c
> >  drivers/sh/superhyway/superhyway.c
> >  drivers/vlynq/vlynq.c
> >  drivers/zorro/zorro-driver.c
> >  sound/ac97/bus.c
> > 
> > Best regards
> > Uwe
> 
> Now queued up.  I can go make a git tag that people can pull from after
> 0-day is finished testing this to verify all is good, if others need it.

Ok, here's a tag that any other subsystem can pull from if they want
these changes in their tree before 5.15-rc1 is out.  I might pull it
into my char-misc-next tree as well just to keep that tree sane as it
seems to pick up new busses on a regular basis...

thanks,

greg k-h

-----------------------------------


The following changes since commit 2734d6c1b1a089fb593ef6a23d4b70903526fe0c:

  Linux 5.14-rc2 (2021-07-18 14:13:49 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git tags/bus_remove_return_void-5.15

for you to fetch changes up to fc7a6209d5710618eb4f72a77cd81b8d694ecf89:

  bus: Make remove callback return void (2021-07-21 11:53:42 +0200)

----------------------------------------------------------------
Bus: Make remove callback return void tag

Tag for other trees/branches to pull from in order to have a stable
place to build off of if they want to add new busses for 5.15.

Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

----------------------------------------------------------------
Uwe Kleine-König (5):
      PCI: endpoint: Make struct pci_epf_driver::remove return void
      s390/cio: Make struct css_driver::remove return void
      s390/ccwgroup: Drop if with an always false condition
      s390/scm: Make struct scm_driver::remove return void
      bus: Make remove callback return void

 arch/arm/common/locomo.c                  | 3 +--
 arch/arm/common/sa1111.c                  | 4 +---
 arch/arm/mach-rpc/ecard.c                 | 4 +---
 arch/mips/sgi-ip22/ip22-gio.c             | 3 +--
 arch/parisc/kernel/drivers.c              | 5 ++---
 arch/powerpc/platforms/ps3/system-bus.c   | 3 +--
 arch/powerpc/platforms/pseries/ibmebus.c  | 3 +--
 arch/powerpc/platforms/pseries/vio.c      | 3 +--
 arch/s390/include/asm/eadm.h              | 2 +-
 arch/sparc/kernel/vio.c                   | 4 +---
 drivers/acpi/bus.c                        | 3 +--
 drivers/amba/bus.c                        | 4 +---
 drivers/base/auxiliary.c                  | 4 +---
 drivers/base/isa.c                        | 4 +---
 drivers/base/platform.c                   | 4 +---
 drivers/bcma/main.c                       | 6 ++----
 drivers/bus/sunxi-rsb.c                   | 4 +---
 drivers/cxl/core.c                        | 3 +--
 drivers/dax/bus.c                         | 4 +---
 drivers/dma/idxd/sysfs.c                  | 4 +---
 drivers/firewire/core-device.c            | 4 +---
 drivers/firmware/arm_scmi/bus.c           | 4 +---
 drivers/firmware/google/coreboot_table.c  | 4 +---
 drivers/fpga/dfl.c                        | 4 +---
 drivers/hid/hid-core.c                    | 4 +---
 drivers/hid/intel-ish-hid/ishtp/bus.c     | 4 +---
 drivers/hv/vmbus_drv.c                    | 5 +----
 drivers/hwtracing/intel_th/core.c         | 4 +---
 drivers/i2c/i2c-core-base.c               | 5 +----
 drivers/i3c/master.c                      | 4 +---
 drivers/input/gameport/gameport.c         | 3 +--
 drivers/input/serio/serio.c               | 3 +--
 drivers/ipack/ipack.c                     | 4 +---
 drivers/macintosh/macio_asic.c            | 4 +---
 drivers/mcb/mcb-core.c                    | 4 +---
 drivers/media/pci/bt8xx/bttv-gpio.c       | 3 +--
 drivers/memstick/core/memstick.c          | 3 +--
 drivers/mfd/mcp-core.c                    | 3 +--
 drivers/misc/mei/bus.c                    | 4 +---
 drivers/misc/tifm_core.c                  | 3 +--
 drivers/mmc/core/bus.c                    | 4 +---
 drivers/mmc/core/sdio_bus.c               | 4 +---
 drivers/net/netdevsim/bus.c               | 3 +--
 drivers/ntb/core.c                        | 4 +---
 drivers/ntb/ntb_transport.c               | 4 +---
 drivers/nubus/bus.c                       | 6 ++----
 drivers/nvdimm/bus.c                      | 3 +--
 drivers/pci/endpoint/pci-epf-core.c       | 7 ++-----
 drivers/pci/pci-driver.c                  | 3 +--
 drivers/pcmcia/ds.c                       | 4 +---
 drivers/platform/surface/aggregator/bus.c | 4 +---
 drivers/platform/x86/wmi.c                | 4 +---
 drivers/pnp/driver.c                      | 3 +--
 drivers/rapidio/rio-driver.c              | 4 +---
 drivers/rpmsg/rpmsg_core.c                | 7 ++-----
 drivers/s390/block/scm_drv.c              | 4 +---
 drivers/s390/cio/ccwgroup.c               | 6 +-----
 drivers/s390/cio/chsc_sch.c               | 3 +--
 drivers/s390/cio/css.c                    | 7 +++----
 drivers/s390/cio/css.h                    | 2 +-
 drivers/s390/cio/device.c                 | 9 +++------
 drivers/s390/cio/eadm_sch.c               | 4 +---
 drivers/s390/cio/scm.c                    | 5 +++--
 drivers/s390/cio/vfio_ccw_drv.c           | 3 +--
 drivers/s390/crypto/ap_bus.c              | 4 +---
 drivers/scsi/scsi_debug.c                 | 3 +--
 drivers/sh/superhyway/superhyway.c        | 8 ++------
 drivers/siox/siox-core.c                  | 4 +---
 drivers/slimbus/core.c                    | 4 +---
 drivers/soc/qcom/apr.c                    | 4 +---
 drivers/spi/spi.c                         | 4 +---
 drivers/spmi/spmi.c                       | 3 +--
 drivers/ssb/main.c                        | 4 +---
 drivers/staging/fieldbus/anybuss/host.c   | 4 +---
 drivers/staging/greybus/gbphy.c           | 4 +---
 drivers/target/loopback/tcm_loop.c        | 5 ++---
 drivers/thunderbolt/domain.c              | 4 +---
 drivers/tty/serdev/core.c                 | 4 +---
 drivers/usb/common/ulpi.c                 | 4 +---
 drivers/usb/serial/bus.c                  | 4 +---
 drivers/usb/typec/bus.c                   | 4 +---
 drivers/vdpa/vdpa.c                       | 4 +---
 drivers/vfio/mdev/mdev_driver.c           | 4 +---
 drivers/virtio/virtio.c                   | 3 +--
 drivers/vlynq/vlynq.c                     | 4 +---
 drivers/vme/vme.c                         | 4 +---
 drivers/xen/xenbus/xenbus.h               | 2 +-
 drivers/xen/xenbus/xenbus_probe.c         | 4 +---
 drivers/zorro/zorro-driver.c              | 3 +--
 include/linux/device/bus.h                | 2 +-
 include/linux/pci-epf.h                   | 2 +-
 sound/ac97/bus.c                          | 6 ++----
 sound/aoa/soundbus/core.c                 | 4 +---
 93 files changed, 107 insertions(+), 263 deletions(-)

Powered by blists - more mailing lists