lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jul 2021 13:36:04 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Andreas Schwab <schwab@...e.de>, Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Bjorn Andersson <bjorn.andersson@...aro.org> Cc: Ulf Hansson <ulf.hansson@...aro.org>, Tobias Schramm <t.schramm@...jaro.org>, Geert Uytterhoeven <geert@...ux-m68k.org>, linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] mmc: mmc_spi: add spi:mmc-spi-slot alias On Thu, Jul 22, 2021 at 1:28 PM Andy Shevchenko <andy.shevchenko@...il.com> wrote: > On Thu, Jul 22, 2021 at 1:03 PM Andreas Schwab <schwab@...e.de> wrote: > > On Jul 21 2021, Andy Shevchenko wrote: > > > > > Or problem is somewhere else? > > > > I don't know. Why does the spi subsystem put "spi:mmc-spi-slot" into > > the modalias file, instead of "of:N(null)T(null)Cmmc-spi-slot" or > > similar? The same problem exists with the other spi port on the board, > > which has a jedec,spi-nor instance attached, also not auto loading. > > You see, there are two unrelated drivers that share the same issue > (the common denominator is that they are SPI devices). I believe the > issue is somewhere in the SPI core rather than here. > > Compare the code of > https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L649 > vs. > https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L56 > > and > > https://elixir.bootlin.com/linux/latest/source/drivers/i2c/i2c-core-base.c#L139 > vs. > https://elixir.bootlin.com/linux/latest/source/drivers/spi/spi.c#L361 > The culprit is this one: > https://lore.kernel.org/lkml/20190618052644.32446-1-bjorn.andersson@linaro.org/ > > and in my humble opinion must be reverted. Oops, I have been too fast. It's not related to SPI in general, sorry guys. But the idea you have got from above, I believe. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists