| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20210722124814.778059-1-arnd@kernel.org>
Date: Thu, 22 Jul 2021 14:48:05 +0200
From: Arnd Bergmann <arnd@...nel.org>
To: linux-arch@...r.kernel.org
Cc: Arnd Bergmann <arnd@...db.de>,
"James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
Al Viro <viro@...iv.linux.org.uk>,
Anton Ivanov <anton.ivanov@...bridgegreys.com>,
Brian Cain <bcain@...eaurora.org>,
Chris Zankel <chris@...kel.net>,
Christian Borntraeger <borntraeger@...ibm.com>,
Christoph Hellwig <hch@....de>, Guo Ren <guoren@...nel.org>,
Heiko Carstens <hca@...ux.ibm.com>,
Helge Deller <deller@....de>, Jeff Dike <jdike@...toit.com>,
Linus Walleij <linus.walleij@...aro.org>,
Max Filippov <jcmvbkbc@...il.com>,
Michal Simek <monstr@...str.eu>,
Richard Weinberger <richard@....at>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Vasily Gorbik <gor@...ux.ibm.com>,
Vineet Gupta <vgupta@...opsys.com>,
Yoshinori Sato <ysato@...rs.sourceforge.jp>,
linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org,
linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mips@...r.kernel.org, linux-parisc@...r.kernel.org,
linux-s390@...r.kernel.org, linux-snps-arc@...ts.infradead.org,
linux-um@...ts.infradead.org, linux-xtensa@...ux-xtensa.org,
uclinux-h8-devel@...ts.sourceforge.jp
Subject: [PATCH v3 0/6] asm-generic: strncpy_from_user/strnlen_user cleanup
From: Arnd Bergmann <arnd@...db.de>
I had run into some regressions for the previous version of this
series, the new version is based on v5.14-rc2 instead.
These two functions appear to be unnecessarily different between
architectures, and the asm-generic version is a bit questionable,
even for NOMMU architectures.
Clean this up to just use the generic library version for anything
that uses the generic version today. I've expanded on the patch
descriptions a little, as suggested by Christoph Hellwig, but I
suspect a more detailed review would uncover additional problems
with the custom versions that are getting removed.
I ended up adding patches for csky and microblaze as they had the
same implementation that I removed elsewhere, these are now gone
as well.
If I hear no objections from architecture maintainers or new
build regressions, I'll queue these up in the asm-generic tree
for 5.15.
Arnd
Link: https://lore.kernel.org/linux-arch/20210515101803.924427-1-arnd@kernel.org/
Arnd Bergmann (9):
asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user
h8300: remove stale strncpy_from_user
hexagon: use generic strncpy/strnlen from_user
arc: use generic strncpy/strnlen from_user
csky: use generic strncpy/strnlen from_user
microblaze: use generic strncpy/strnlen from_user
asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user
asm-generic: remove extra strn{cpy_from,len}_user declarations
asm-generic: reverse GENERIC_{STRNCPY_FROM,STRNLEN}_USER symbols
arch/alpha/Kconfig | 2 -
arch/arc/include/asm/uaccess.h | 72 -------------
arch/arc/mm/extable.c | 12 ---
arch/arm/Kconfig | 2 -
arch/arm64/Kconfig | 2 -
arch/csky/include/asm/uaccess.h | 6 --
arch/csky/lib/usercopy.c | 102 ------------------
arch/h8300/kernel/h8300_ksyms.c | 2 -
arch/h8300/lib/Makefile | 2 +-
arch/h8300/lib/strncpy.S | 35 ------
arch/hexagon/include/asm/uaccess.h | 31 ------
arch/hexagon/kernel/hexagon_ksyms.c | 1 -
arch/hexagon/mm/Makefile | 2 +-
arch/hexagon/mm/strnlen_user.S | 126 ----------------------
arch/ia64/Kconfig | 2 +
arch/m68k/Kconfig | 2 -
arch/microblaze/include/asm/uaccess.h | 19 +---
arch/microblaze/kernel/microblaze_ksyms.c | 3 -
arch/microblaze/lib/uaccess_old.S | 90 ----------------
arch/mips/Kconfig | 2 +
arch/nds32/Kconfig | 2 -
arch/nios2/Kconfig | 2 -
arch/openrisc/Kconfig | 2 -
arch/parisc/Kconfig | 2 +-
arch/powerpc/Kconfig | 2 -
arch/riscv/Kconfig | 2 -
arch/s390/Kconfig | 2 +
arch/sh/Kconfig | 2 -
arch/sparc/Kconfig | 2 -
arch/um/Kconfig | 2 +
arch/um/include/asm/uaccess.h | 5 +-
arch/um/kernel/skas/uaccess.c | 14 ++-
arch/x86/Kconfig | 2 -
arch/xtensa/Kconfig | 3 +-
arch/xtensa/include/asm/uaccess.h | 3 +-
include/asm-generic/uaccess.h | 52 ++-------
lib/Kconfig | 10 +-
37 files changed, 43 insertions(+), 581 deletions(-)
delete mode 100644 arch/h8300/lib/strncpy.S
delete mode 100644 arch/hexagon/mm/strnlen_user.S
--
2.29.2
Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
Cc: Al Viro <viro@...iv.linux.org.uk>
Cc: Anton Ivanov <anton.ivanov@...bridgegreys.com>
Cc: Brian Cain <bcain@...eaurora.org>
Cc: Chris Zankel <chris@...kel.net>
Cc: Christian Borntraeger <borntraeger@...ibm.com>
Cc: Christoph Hellwig <hch@....de>
Cc: Guo Ren <guoren@...nel.org>
Cc: Heiko Carstens <hca@...ux.ibm.com>
Cc: Helge Deller <deller@....de>
Cc: Jeff Dike <jdike@...toit.com>
Cc: Linus Walleij <linus.walleij@...aro.org>
Cc: Max Filippov <jcmvbkbc@...il.com>
Cc: Michal Simek <monstr@...str.eu>
Cc: Richard Weinberger <richard@....at>
Cc: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Vasily Gorbik <gor@...ux.ibm.com>
Cc: Vineet Gupta <vgupta@...opsys.com>
Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc: linux-arch@...r.kernel.org
Cc: linux-csky@...r.kernel.org
Cc: linux-hexagon@...r.kernel.org
Cc: linux-ia64@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
Cc: linux-mips@...r.kernel.org
Cc: linux-parisc@...r.kernel.org
Cc: linux-s390@...r.kernel.org
Cc: linux-snps-arc@...ts.infradead.org
Cc: linux-um@...ts.infradead.org
Cc: linux-xtensa@...ux-xtensa.org
Cc: uclinux-h8-devel@...ts.sourceforge.jp
Powered by blists - more mailing lists