lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 22 Jul 2021 18:31:16 +0200
From:   Greg Kroah-Hartman <>
Cc:     Greg Kroah-Hartman <>,, Peter Xu <>,
        "Kirill A. Shutemov" <>,
        Mike Rapoport <>,
        Axel Rasmussen <>,
        Andrea Arcangeli <>,
        Hugh Dickins <>,
        Jerome Glisse <>,
        Alexander Viro <>,
        Brian Geffon <>,
        "Dr . David Alan Gilbert" <>,
        Joe Perches <>,
        Lokesh Gidra <>,
        Mina Almasry <>,
        Oliver Upton <>, Shaohua Li <>,
        Shuah Khan <>,
        Stephen Rothwell <>,
        Wang Qing <>,
        Andrew Morton <>,
        Linus Torvalds <>,
        Mike Kravetz <>
Subject: [PATCH 5.10 085/125] mm/thp: simplify copying of huge zero page pmd when fork

From: Peter Xu <>

commit 5fc7a5f6fd04bc18f309d9f979b32ef7d1d0a997 upstream.

Patch series "mm/uffd: Misc fix for uffd-wp and one more test".

This series tries to fix some corner case bugs for uffd-wp on either thp
or fork().  Then it introduced a new test with pagemap/pageout.

Patch layout:

Patch 1:    cleanup for THP, it'll slightly simplify the follow up patches
Patch 2-4:  misc fixes for uffd-wp here and there; please refer to each patch
Patch 5:    add pagemap support for uffd-wp
Patch 6:    add pagemap/pageout test for uffd-wp

The last test introduced can also verify some of the fixes in previous
patches, as the test will fail without the fixes.  However it's not easy
to verify all the changes in patch 2-4, but hopefully they can still be
properly reviewed.

Note that if considering the ongoing uffd-wp shmem & hugetlbfs work, patch
5 will be incomplete as it's missing e.g.  hugetlbfs part or the special
swap pte detection.  However that's not needed in this series, and since
that series is still during review, this series does not depend on that
one (the last test only runs with anonymous memory, not file-backed).  So
this series can be merged even before that series.

This patch (of 6):

Huge zero page is handled in a special path in copy_huge_pmd(), however it
should share most codes with a normal thp page.  Trying to share more code
with it by removing the special path.  The only leftover so far is the
huge zero page refcounting (mm_get_huge_zero_page()), because that's
separately done with a global counter.

This prepares for a future patch to modify the huge pmd to be installed,
so that we don't need to duplicate it explicitly into huge zero page case

Signed-off-by: Peter Xu <>
Cc: Kirill A. Shutemov <>
Cc: Mike Kravetz <>,
Cc: Mike Rapoport <>
Cc: Axel Rasmussen <>
Cc: Andrea Arcangeli <>
Cc: Hugh Dickins <>
Cc: Jerome Glisse <>
Cc: Alexander Viro <>
Cc: Brian Geffon <>
Cc: "Dr . David Alan Gilbert" <>
Cc: Joe Perches <>
Cc: Lokesh Gidra <>
Cc: Mina Almasry <>
Cc: Oliver Upton <>
Cc: Shaohua Li <>
Cc: Shuah Khan <>
Cc: Stephen Rothwell <>
Cc: Wang Qing <>
Signed-off-by: Andrew Morton <>
Signed-off-by: Linus Torvalds <>
Signed-off-by: Greg Kroah-Hartman <>
 mm/huge_memory.c |    9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -1074,17 +1074,13 @@ int copy_huge_pmd(struct mm_struct *dst_
 	 * a page table.
 	if (is_huge_zero_pmd(pmd)) {
-		struct page *zero_page;
 		 * get_huge_zero_page() will never allocate a new page here,
 		 * since we already have a zero page to copy. It just takes a
 		 * reference.
-		zero_page = mm_get_huge_zero_page(dst_mm);
-		set_huge_zero_page(pgtable, dst_mm, vma, addr, dst_pmd,
-				zero_page);
-		ret = 0;
-		goto out_unlock;
+		mm_get_huge_zero_page(dst_mm);
+		goto out_zero_page;
 	src_page = pmd_page(pmd);
@@ -1110,6 +1106,7 @@ int copy_huge_pmd(struct mm_struct *dst_
 	page_dup_rmap(src_page, true);
 	add_mm_counter(dst_mm, MM_ANONPAGES, HPAGE_PMD_NR);
 	pgtable_trans_huge_deposit(dst_mm, dst_pmd, pgtable);

Powered by blists - more mailing lists