linux-kernel - Re: [PATCH] Input: pm8941-pwrkey

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YPsd74LoRtB9tTKK@google.com>
Date:   Fri, 23 Jul 2021 12:52:15 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     linux-input@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        David Collins <collinsd@...eaurora.org>,
        satya priya <skakit@...eaurora.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue

On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote:
> Quoting Dmitry Torokhov (2021-07-23 12:39:02)
> > There is absolutely no reason to use comma operator in this code, 2
> > separate statements make much more sense.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> > ---
> 
> Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
> PON_HLOS PMIC peripheral")

It actually predates this patch and also not really a fix as the
original code ends up working properly, but looks weird.

> Reviewed-by: Stephen Boyd <swboyd@...omium.org>

Thanks!

-- 
Dmitry