linux-kernel - Re: [PATCH AUTOSEL 4.19 31/39] arm64: dts: ls208xa: remove bus-num from dspi node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210723201104.GC22684@duo.ucw.cz>
Date:   Fri, 23 Jul 2021 22:11:04 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Mian Yousaf Kaukab <ykaukab@...e.de>,
        Shawn Guo <shawnguo@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 31/39] arm64: dts: ls208xa: remove bus-num
 from dspi node

Hi!

> [ Upstream commit 8240c972c1798ea013cbb407722295fc826b3584 ]
> 
> On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
> then its probe fails with the following warning:
> 
> [   10.471363] couldn't get idr
> [   10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
> ...
> [   10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
> [   10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
> 
> Reason for the failure is that bus-num property is set for dspi node.
> However, bus-num property is not set for the qspi node. If probe for
> spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
> Call to spi_register_controller() from spi-fsl-dspi driver then fails.
> Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
> optional") bus-num property is optional. Remove bus-num property from
> dspi node to fix the issue.

According to changelog this depends on 29d2daf2c33c. Than one is
present in 5.10-stable, but not in 4.19-stable, AFAICT.

Best regards,
								Pavel

> +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> @@ -479,7 +479,6 @@ dspi: spi@...0000 {
>  			clocks = <&clockgen 4 3>;
>  			clock-names = "dspi";
>  			spi-num-chipselects = <5>;
> -			bus-num = <0>;
>  		};
>  
>  		esdhc: esdhc@...0000 {

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)