[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=X8xgn=ueyryFZVA-VNLEU_sk8H29D08JaEpw2Qh2OFqQ@mail.gmail.com>
Date: Fri, 23 Jul 2021 16:05:44 -0700
From: Doug Anderson <dianders@...omium.org>
To: "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Cc: Bjorn Andersson <bjorn.andersson@...aro.org>,
Niklas Cassel <niklas.cassel@...aro.org>,
Akhil P Oommen <akhilpo@...eaurora.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
Ulf Hansson <ulf.hansson@...aro.org>,
Andy Gross <agross@...nel.org>,
Niklas Cassel <nks@...wful.org>,
LKML <linux-kernel@...r.kernel.org>,
Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH v2] PM: AVS: qcom-cpr: Use nvmem_cell_read_variable_le_u32()
Rafael / Bjorn,
On Fri, May 21, 2021 at 1:45 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> Let's delete the private function cpr_read_efuse() since it does the
> basically the same thing as the new API call
> nvmem_cell_read_variable_le_u32().
>
> Differences between the new API call and the old private function:
> * less error printing (I assume this is OK).
> * will give an error if the value doesn't fit in 32-bits (the old code
> would have truncated silently).
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> I haven't done any more than compile-test this. Mostly I'm just
> writing this patch because it helped provide inspiration for the
> general API function.
>
> Changes in v2:
> - Resending v1 as a singleton patch; dependency is merged in mainline.
>
> drivers/soc/qcom/cpr.c | 43 +++++-------------------------------------
> 1 file changed, 5 insertions(+), 38 deletions(-)
Are either of you interested in landing this? I guess Rafael landed
most of the recent changes to this driver, but it used to be under the
'power' directory. Now that it's under 'drivers/soc/qcom' maybe it
should go through Bjorn's tree?
-Doug
Powered by blists - more mailing lists