lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Jul 2021 23:57:47 -0400 From: Sasha Levin <sashal@...nel.org> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org Cc: Christoph Hellwig <hch@....de>, Leizhen <thunder.leizhen@...wei.com>, "Darrick J . Wong" <djwong@...nel.org>, Matthew Wilcox <willy@...radead.org>, Sasha Levin <sashal@...nel.org>, linux-xfs@...r.kernel.org, linux-fsdevel@...r.kernel.org Subject: [PATCH AUTOSEL 5.10 16/17] iomap: remove the length variable in iomap_seek_hole From: Christoph Hellwig <hch@....de> [ Upstream commit 49694d14ff68fa4b5f86019dbcfb44a8bd213e58 ] The length variable is rather pointless given that it can be trivially deduced from offset and size. Also the initial calculation can lead to KASAN warnings. Signed-off-by: Christoph Hellwig <hch@....de> Reported-by: Leizhen (ThunderTown) <thunder.leizhen@...wei.com> Reviewed-by: Darrick J. Wong <djwong@...nel.org> Signed-off-by: Darrick J. Wong <djwong@...nel.org> Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org> Signed-off-by: Sasha Levin <sashal@...nel.org> --- fs/iomap/seek.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/fs/iomap/seek.c b/fs/iomap/seek.c index 271edcc84a28..220c306167f7 100644 --- a/fs/iomap/seek.c +++ b/fs/iomap/seek.c @@ -140,23 +140,20 @@ loff_t iomap_seek_hole(struct inode *inode, loff_t offset, const struct iomap_ops *ops) { loff_t size = i_size_read(inode); - loff_t length = size - offset; loff_t ret; /* Nothing to be found before or beyond the end of the file. */ if (offset < 0 || offset >= size) return -ENXIO; - while (length > 0) { - ret = iomap_apply(inode, offset, length, IOMAP_REPORT, ops, - &offset, iomap_seek_hole_actor); + while (offset < size) { + ret = iomap_apply(inode, offset, size - offset, IOMAP_REPORT, + ops, &offset, iomap_seek_hole_actor); if (ret < 0) return ret; if (ret == 0) break; - offset += ret; - length -= ret; } return offset; -- 2.30.2
Powered by blists - more mailing lists