linux-kernel - Re: [PATH v2] scsi: scsi_dh_rdac: Avoid crash during rdac_bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1113b04-e320-a12b-5a59-ec7479d5eec1@acm.org>
Date:   Thu, 22 Jul 2021 21:04:18 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Ye Bin <yebin10@...wei.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATH v2] scsi: scsi_dh_rdac: Avoid crash during rdac_bus_attach

On 1/12/21 10:31 PM, Ye Bin wrote:
>  	sdev->handler_data = NULL;
> +	synchronize_rcu();
>  	kfree(h);

What is the purpose of the new synchronize_rcu() call? If its purpose is
to wait until *h is no longer in use, please use kfree_rcu() instead.

Thanks,

Bart.