linux-kernel - Re: [PATCH] gpu: host1x: select CONFIG_SYNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jul 2021 12:17:56 +0300
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Arnd Bergmann <arnd@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Mikko Perttunen <mperttunen@...dia.com>
Cc:     Arnd Bergmann <arnd@...db.de>, dri-devel@...ts.freedesktop.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpu: host1x: select CONFIG_SYNC_FILE

Hi Arnd,

I think the best fix for this is to just remove that function -- it is 
currently not used anywhere. I posted a patch to do that, but Thierry is 
currently on vacation so it hasn't been picked up yet.

thanks,
Mikko

On 7/23/21 12:14 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> With the addition of the DMA fence, the host1x driver now fails to
> build without the sync_file helper:
> 
> arm-linux-gnueabi-ld: drivers/gpu/host1x/fence.o: in function `host1x_fence_create_fd':
> fence.c:(.text+0x624): undefined reference to `sync_file_create'
> 
> Fixes: ad0529424def ("gpu: host1x: Add DMA fence implementation")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/gpu/host1x/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
> index 6dab94adf25e..6f7ea1720a39 100644
> --- a/drivers/gpu/host1x/Kconfig
> +++ b/drivers/gpu/host1x/Kconfig
> @@ -3,6 +3,7 @@ config TEGRA_HOST1X
>   	tristate "NVIDIA Tegra host1x driver"
>   	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
>   	select IOMMU_IOVA
> +	select SYNC_FILE
>   	help
>   	  Driver for the NVIDIA Tegra host1x hardware.
>   
>