linux-kernel - Re: [PATCH 3/8] tty: don't store semi-state into tty drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 23 Jul 2021 03:23:48 -0700
From:   Max Filippov <jcmvbkbc@...il.com>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        "James E.J. Bottomley" <James.Bottomley@...senpartnership.com>,
        Helge Deller <deller@....de>, Chris Zankel <chris@...kel.net>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Felipe Balbi <balbi@...nel.org>
Subject: Re: [PATCH 3/8] tty: don't store semi-state into tty drivers

On Fri, Jul 23, 2021 at 12:43 AM Jiri Slaby <jslaby@...e.cz> wrote:
>
> When a tty driver pointer is used as a return value of struct
> console's device() hook, don't store a semi-state into global variable
> which holds the tty driver. It could mean console::device() would return
> a bogus value. This is important esp. after the next patch where we
> switch from alloc_tty_driver to tty_alloc_driver. tty_alloc_driver
> returns ERR_PTR in case of error and that might have unexpected results
> as the code doesn't expect this.
>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>
> Cc: Helge Deller <deller@....de>
> Cc: Chris Zankel <chris@...kel.net>
> Cc: Max Filippov <jcmvbkbc@...il.com>
> Cc: Laurentiu Tudor <laurentiu.tudor@....com>
> Cc: Felipe Balbi <balbi@...nel.org>
> ---
>  arch/m68k/emu/nfcon.c                  | 27 +++++++++++---------
>  arch/parisc/kernel/pdc_cons.c          | 28 +++++++++++----------
>  arch/xtensa/platforms/iss/console.c    | 33 +++++++++++++-----------
>  drivers/tty/amiserial.c                | 35 ++++++++++++++------------
>  drivers/tty/ehv_bytechan.c             | 28 ++++++++++++---------
>  drivers/tty/hvc/hvsi.c                 | 35 ++++++++++++++------------
>  drivers/usb/gadget/function/u_serial.c | 32 ++++++++++++-----------
>  7 files changed, 119 insertions(+), 99 deletions(-)

Reviewed-by: Max Filippov <jcmvbkbc@...il.com>

-- 
Thanks.
-- Max