linux-kernel - Re: [RFC] dsa: register every port with of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YPqoSlzdZhPdyUKN@Ansuel-xps.localdomain>
Date:   Fri, 23 Jul 2021 13:30:18 +0200
From:   Ansuel Smith <ansuelsmth@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     andrew@...n.ch, davem@...emloft.net, f.fainelli@...il.com,
        kuba@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, olteanv@...il.com, vivien.didelot@...il.com
Subject: Re: [RFC] dsa: register every port with of_platform

On Fri, Jul 23, 2021 at 01:25:02PM +0200, Michael Walle wrote:
> Am 2021-07-23 13:18, schrieb Ansuel Smith:
> > On Fri, Jul 23, 2021 at 01:13:28PM +0200, Michael Walle wrote:
> > > > The declaration of a different mac-addr using the nvmem framework is
> > > > currently broken. The dsa code uses the generic of_get_mac_address where
> > > > the nvmem function requires the device node to be registered in the
> > > > of_platform to be found by of_find_device_by_node. Register every port
> > > 
> > > Which tree are you on? This should be fixed with
> > > 
> > > f10843e04a07  of: net: fix of_get_mac_addr_nvmem() for non-platform
> > > devices
> > > 
> > > -michael
> > 
> > Thx a lot for the hint. So yes I missed that the problem was already
> > fixed. Sorry for the mess. Any idea if that will be backported?
> 
> I didn't include a Fixes tag, so it won't be automatically
> backported. Also I'm not sure if it qualifies for the stable trees
> because no in-tree users seem to be affected, no?
> 
> -michael

Also the patch seems very large. Anyway again thx a lot for the work and
the quick hint. Time to backport to 5.10 and 5.4 for openwrt.